Browser Plugin: New Implementation (Browser Side)

content/browser/renderer_host/render_widget_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 
 #include <math.h>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 217 matching lines @@
     return view_->GetCompositingSurface();
   return gfx::GLSurfaceHandle();
 }
 
 void RenderWidgetHostImpl::CompositingSurfaceUpdated() {
   GpuSurfaceTracker::Get()->SetSurfaceHandle(
       surface_id_, GetCompositingSurface());
   process_->SurfaceUpdated(surface_id_);
 }
 
+void RenderWidgetHostImpl::ResetFlags() {

[awong, 2012/09/06 00:23:27]

This kind of laundry list make it easy for future maintainers to introduce bugs.

Is there a unittest that could somehow assert correct behavior here, or some way
to succinctly describe how someone can verify that the set of variables here is
correct and complete?

[lazyboy, 2012/09/06 04:33:53]

I agree, I'll let Fady comment on the ResetFlags() call from BPGHelper. My
suspicion is that we might be interested in the ack and size variable only, if
that's the case I can write a test for it.

+  // Must reset these to ensure that mouse move/wheel events work with a new
+  // renderer.
+  mouse_move_pending_ = false;
+  next_mouse_move_.reset();
+  mouse_wheel_pending_ = false;
+  coalesced_mouse_wheel_events_.clear();
+
+  // Must reset these to ensure that SelectRange works with a new renderer.
+  select_range_pending_ = false;
+  next_selection_range_.reset();
+
+  // Must reset these to ensure that gesture events work with a new renderer.
+  gesture_event_filter_->Reset();
+
+  // Must reset these to ensure that keyboard events work with a new renderer.
+  key_queue_.clear();
+  suppress_next_char_events_ = false;
+
+  // Reset some fields in preparation for recovering from a crash.
+  resize_ack_pending_ = false;
+  repaint_ack_pending_ = false;
+
+  in_flight_size_.SetSize(0, 0);
+  current_size_.SetSize(0, 0);
+  is_hidden_ = false;
+  is_accelerated_compositing_active_ = false;
+
+  // Reset this to ensure the hung renderer mechanism is working properly.
+  in_flight_event_count_ = 0;
+}
+
 void RenderWidgetHostImpl::Init() {
   DCHECK(process_->HasConnection());
 
   renderer_initialized_ = true;
 
   GpuSurfaceTracker::Get()->SetSurfaceHandle(
       surface_id_, GetCompositingSurface());
 
   // Send the ack along with the information on placement.
   Send(new ViewMsg_CreatingNew_ACK(routing_id_, GetNativeViewId()));
@@ skipping 835 matching lines @@
                                                  base::TimeDelta interval) {
   Send(new ViewMsg_UpdateVSyncParameters(GetRoutingID(), timebase, interval));
 }
 
 void RenderWidgetHostImpl::RendererExited(base::TerminationStatus status,
                                           int exit_code) {
   // Clearing this flag causes us to re-create the renderer when recovering
   // from a crashed renderer.
   renderer_initialized_ = false;
 
-  // Must reset these to ensure that mouse move/wheel events work with a new
-  // renderer.
-  mouse_move_pending_ = false;
-  next_mouse_move_.reset();
-  mouse_wheel_pending_ = false;
-  coalesced_mouse_wheel_events_.clear();
-
-  // Must reset these to ensure that SelectRange works with a new renderer.
-  select_range_pending_ = false;
-  next_selection_range_.reset();
-
-  // Must reset these to ensure that gesture events work with a new renderer.
-  gesture_event_filter_->Reset();
-
-  // Must reset these to ensure that keyboard events work with a new renderer.
-  key_queue_.clear();
-  suppress_next_char_events_ = false;
-
-  // Reset some fields in preparation for recovering from a crash.
-  resize_ack_pending_ = false;
-  repaint_ack_pending_ = false;
-
-  in_flight_size_.SetSize(0, 0);
-  current_size_.SetSize(0, 0);
-  is_hidden_ = false;
-  is_accelerated_compositing_active_ = false;
-
-  // Reset this to ensure the hung renderer mechanism is working properly.
-  in_flight_event_count_ = 0;
+  ResetFlags();
 
   if (view_) {
     GpuSurfaceTracker::Get()->SetSurfaceHandle(surface_id_,
                                                gfx::GLSurfaceHandle());
     view_->RenderViewGone(status, exit_code);
     view_ = NULL;  // The View should be deleted by RenderViewGone.
   }
 
   BackingStoreManager::RemoveBackingStore(this);
 }
@@ skipping 906 matching lines @@
   // indicate that no callback is in progress (i.e. without this line
   // DelayedAutoResized will not get called again).
   new_auto_size_.SetSize(0, 0);
   if (!should_auto_resize_)
     return;
 
   OnRenderAutoResized(new_size);
 }
 
 }  // namespace content