chromeos: Fix pixelated icons in app list and launcher (part 3)

chrome/browser/ui/ash/launcher/launcher_app_icon_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/launcher_app_icon_loader.h"
 
+#include "base/stl_util.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 
 namespace {
 
 const extensions::Extension* GetExtensionByID(Profile* profile,
                                               const std::string& id) {
   ExtensionService* service = profile->GetExtensionService();
   if (!service)
     return NULL;
   return service->extensions()->GetByID(id);
 }
 
 }  // namespace
 
 
 LauncherAppIconLoader::LauncherAppIconLoader(
     Profile* profile,
     ChromeLauncherController* controller)
     : profile_(profile),
       host_(controller) {
 }
 
 LauncherAppIconLoader::~LauncherAppIconLoader() {
+  STLDeleteContainerPairFirstPointers(map_.begin(), map_.end());
 }
 
 void LauncherAppIconLoader::FetchImage(const std::string& id) {
-  for (ImageLoaderIDToExtensionIDMap::const_iterator i = map_.begin();
+  for (ImageToExtensionIDMap::const_iterator i = map_.begin();
        i != map_.end(); ++i) {
     if (i->second == id)
       return;  // Already loading the image.
   }
 
   const extensions::Extension* extension = GetExtensionByID(profile_, id);
   if (!extension)
     return;
-  if (!image_loader_.get())
-    image_loader_.reset(new ImageLoadingTracker(this));
-  map_[image_loader_->next_id()] = id;
-  image_loader_->LoadImage(
+
+  extensions::IconImage* image = new extensions::IconImage(
       extension,
-      extension->GetIconResource(extension_misc::EXTENSION_ICON_SMALL,
-                                 ExtensionIconSet::MATCH_BIGGER),
-      gfx::Size(extension_misc::EXTENSION_ICON_SMALL,
-                extension_misc::EXTENSION_ICON_SMALL),
-      ImageLoadingTracker::CACHE);
+      extension->icons(),
+      extension_misc::EXTENSION_ICON_SMALL,
+      extensions::Extension::GetDefaultIcon(true),
+      this);
+  // |map_| takes ownership if |image|.

[tbarzic, 2012/09/07 17:14:07]

s/if/of

[xiyuan, 2012/09/07 20:05:59]

Done.

+  map_[image] = id;
+
+  OnExtensionIconImageChanged(image);

[tbarzic, 2012/09/07 17:14:07]

optional:
host_->SetAppImage(id, image->image_skia());

[xiyuan, 2012/09/07 20:05:59]

Done.

 }
 
-void LauncherAppIconLoader::OnImageLoaded(const gfx::Image& image,
-                                          const std::string& extension_id,
-                                          int index) {
-  ImageLoaderIDToExtensionIDMap::iterator i = map_.find(index);
+void LauncherAppIconLoader::ClearImage(const std::string& id) {
+  for (ImageToExtensionIDMap::iterator i = map_.begin();
+       i != map_.end(); ++i) {
+    if (i->second == id) {
+      delete i->first;
+      map_.erase(i);
+      break;
+    }
+  }
+}
+
+void LauncherAppIconLoader::OnExtensionIconImageChanged(
+    extensions::IconImage* image) {
+  ImageToExtensionIDMap::iterator i = map_.find(image);
   if (i == map_.end())
-    return;  // The tab has since been removed, do nothing.
+    return;  // The image has been removed, do nothing.
 

[pkotwicz, 2012/09/07 19:24:49]

Optional: I think you can delete i->first and erase it from the map here.
ImageSkia is refcounted so using the ImageSkia should still be valid after this
function has terminated.

[xiyuan, 2012/09/07 20:05:59]

We need to keep IconImage alive so that it could load additional reps when
needed (e.g. when switching monitors).

-  std::string id = i->second;
-  map_.erase(i);
-  if (image.IsEmpty())
-    host_->SetAppImage(id, extensions::Extension::GetDefaultIcon(true));
-  else
-    host_->SetAppImage(id, *image.ToImageSkia());
+  host_->SetAppImage(i->second, image->image_skia());
 }