Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/browser/android/tab_android.h

Issue 10861042: Add Android's context menu handler used on the NTP. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Switch to using a weakptr instead of callback obj. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.h
diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h
index d60da3905678926b266323ca67c1a3c25a247275..fb674e27096ade73341c449e0191be1ca8d2c240 100644
--- a/chrome/browser/android/tab_android.h
+++ b/chrome/browser/android/tab_android.h
@@ -9,10 +9,11 @@
#include "base/android/jni_helper.h"
#include "base/android/scoped_java_ref.h"
+#include "base/memory/weak_ptr.h"
#include "base/string16.h"
+class ContextMenuHandler;
class GURL;
-class OnContextMenuItemSelectedCallBack;
class SkBitmap;
namespace browser_sync {
@@ -50,7 +51,7 @@ class TabAndroid {
// Called to show a custom context menu. Used by the NTP.
virtual void ShowCustomContextMenu(
const content::ContextMenuParams& params,
- OnContextMenuItemSelectedCallBack* callback) = 0;
+ const base::WeakPtr<ContextMenuHandler>& callback) = 0;
virtual void ShowSelectFileDialog(
const base::android::ScopedJavaLocalRef<jobject>& select_file) = 0;

Powered by Google App Engine
This is Rietveld 408576698