Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 10861018: Fix memory leaks from adding GPU memory to task manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 241e8ca01ecc0aa725efb47a0673705c0dde48a7..9b6ee0d6e902490782a0de57af3d5eb4ff044716 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -980,15 +980,17 @@ class TaskManagerModelGpuDataManagerObserver
NotifyVideoMemoryUsageStats,
video_memory_usage_stats));
}
- delete this;
}
};
void TaskManagerModel::RefreshVideoMemoryUsageStats()
{
if (pending_video_memory_usage_stats_update_) return;
+ if (!video_memory_usage_stats_observer_.get()) {
+ video_memory_usage_stats_observer_.reset(
+ new TaskManagerModelGpuDataManagerObserver());
+ }
pending_video_memory_usage_stats_update_ = true;
- new TaskManagerModelGpuDataManagerObserver;
content::GpuDataManager::GetInstance()->RequestVideoMemoryUsageStatsUpdate();
}

Powered by Google App Engine
This is Rietveld 408576698