Fix the failed case AndroidProviderBackendTest.UpdateFavicon on Android

chrome/browser/history/android/android_provider_backend_unittest.cc

Index: chrome/browser/history/android/android_provider_backend_unittest.cc
diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc
index 31a84620498684387a3db5916ee3bea32a08d3de..4e4b463760f42e6991d9cac30455d5cb21b2b438 100644
--- a/chrome/browser/history/android/android_provider_backend_unittest.cc
+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc
@@ -1138,7 +1138,10 @@ TEST_F(AndroidProviderBackendTest, UpdateFavicon) {
   // Set favicon.
   std::vector<unsigned char> data;
   data.push_back('1');
-  update_row1.set_favicon(base::RefCountedBytes::TakeVector(&data));
+  // Keep the pointer of RefCountedBytes for it's the expected result
+  // which will be compared with the result of GetFavicon
+  base::RefCountedBytes *data_bytes = base::RefCountedBytes::TakeVector(&data);
+  update_row1.set_favicon(data_bytes);
   update_args.push_back(UTF8ToUTF16(row1.raw_url()));
   delegate_.ResetDetails();
   ASSERT_TRUE(backend->UpdateHistoryAndBookmarks(update_row1, "url = ?",
@@ -1158,7 +1161,7 @@ TEST_F(AndroidProviderBackendTest, UpdateFavicon) {
   std::vector<unsigned char> png_icon_data;
   EXPECT_TRUE(thumbnail_db_.GetFavicon(icon_mapping.icon_id, &last_updated,
                                        &png_icon_data, NULL, NULL));
-  EXPECT_EQ(data, png_icon_data);
+  EXPECT_EQ(data_bytes->data(), png_icon_data);
 
   // Remove favicon.
   HistoryAndBookmarkRow update_row2;