Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4508)

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 10861006: Fix the failed case AndroidProviderBackendTest.UpdateFavicon on Android (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/android_provider_backend_unittest.cc
diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc
index 31a84620498684387a3db5916ee3bea32a08d3de..edb2b84250472735403ce2583d6ca732aabfc79e 100644
--- a/chrome/browser/history/android/android_provider_backend_unittest.cc
+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc
@@ -1139,6 +1139,9 @@ TEST_F(AndroidProviderBackendTest, UpdateFavicon) {
std::vector<unsigned char> data;
data.push_back('1');
update_row1.set_favicon(base::RefCountedBytes::TakeVector(&data));
+ // the content of data is swapped, so reset it to compare with
+ // the result of GetFavicon
+ data.push_back('1');
pkotwicz 2012/08/20 14:17:29 You can actually use new RefCountedBytes(data) ins
update_args.push_back(UTF8ToUTF16(row1.raw_url()));
delegate_.ResetDetails();
ASSERT_TRUE(backend->UpdateHistoryAndBookmarks(update_row1, "url = ?",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698