chrome/common/pref_names.h - Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pref_names.h

Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressing review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/pref_names.h

diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h

index 5d3731f02fb05845c2f233aed7ead704ed6e1dcb..d90e6f27add14ebc7e1878a96a497eeb948b6f85 100644

--- a/chrome/common/pref_names.h

+++ b/chrome/common/pref_names.h

@@ -527,26 +527,8 @@ extern const char kNtpCustomLogoStart[];

extern const char kNtpCustomLogoEnd[];

extern const char kNtpPromoVersion[];

extern const char kNtpPromoLocale[];

-extern const char kNtpPromoStart[];

-extern const char kNtpPromoEnd[];

-extern const char kNtpPromoLine[];

-#if defined(OS_ANDROID)

-extern const char kNtpPromoLineLong[];

-extern const char kNtpPromoActionType[];

-extern const char kNtpPromoActionArgs[];

-#endif // defined(OS_ANDROID)

-extern const char kNtpPromoClosed[];

-extern const char kNtpPromoGroup[];

-extern const char kNtpPromoNumGroups[];

-extern const char kNtpPromoInitialSegment[];

-extern const char kNtpPromoIncrement[];

-extern const char kNtpPromoGroupTimeSlice[];

-extern const char kNtpPromoGroupMax[];

-extern const char kNtpPromoViews[];

-extern const char kNtpPromoViewsMax[];

extern const char kNtpPromoPlatform[];

extern const char kNtpPromoBuild[];

achuithb 2012/08/23 06:01:24 Please remove these two as well. This is cruft tha

aruslan 2012/08/23 18:06:23 Done.

-extern const char kNtpPromoGplusRequired[];

extern const char kNtpWebStoreEnabled[];

extern const char kNtpAppPageNames[];

« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/pref_names.cc » ('j') | no next file with comments »