Index: base/metrics/histogram_flattener.h |
=================================================================== |
--- base/metrics/histogram_flattener.h (revision 151415) |
+++ base/metrics/histogram_flattener.h (working copy) |
@@ -22,11 +22,19 @@ |
virtual void RecordDelta(const base::Histogram& histogram, |
const base::Histogram::SampleSet& snapshot) = 0; |
- // Record various errors found during attempts to record histograms. |
- virtual void InconsistencyDetected(int problem) = 0; |
- virtual void UniqueInconsistencyDetected(int problem) = 0; |
- virtual void SnapshotProblemResolved(int amount) = 0; |
+ // Will be called each time when a type of Inconsistenies is seen on a |
jar (doing other things)
2012/08/20 02:41:49
nit: remove either "each time" or "when".
Clarify
|
+ // histogram. |
+ virtual void InconsistencyDetected(Histogram::Inconsistencies problem) = 0; |
+ // Will be called when a type of Inconsistenies is seen for the first time |
+ // on a histogram. |
jar (doing other things)
2012/08/20 02:41:49
nit: clarify who/when this is called, such as was
|
+ virtual void UniqueInconsistencyDetected( |
+ Histogram::Inconsistencies problem) = 0; |
+ |
+ // Will be called when the logged samples count of a histogram has |
+ // inconsistency. |amount| is the difference. |
jar (doing other things)
2012/08/20 02:41:49
nit: Clarify this line, possibly by replacing the
|
+ virtual void InconsistencyDetectedInLoggedCount(int amount) = 0; |
+ |
protected: |
HistogramFlattener() {} |
virtual ~HistogramFlattener() {} |