Added warning when URLRequestContextGetter leaks.

net/url_request/url_request_context_getter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_context_getter.h"
 
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "net/url_request/url_request_context.h"
 
 namespace net {
 
 URLRequestContextGetter::URLRequestContextGetter() {}
 
 URLRequestContextGetter::~URLRequestContextGetter() {}
 
 void URLRequestContextGetter::OnDestruct() const {
   scoped_refptr<base::SingleThreadTaskRunner> network_task_runner =
       GetNetworkTaskRunner();
   DCHECK(network_task_runner);
   if (network_task_runner) {
     if (network_task_runner->BelongsToCurrentThread()) {
       delete this;
     } else {
-      network_task_runner->DeleteSoon(FROM_HERE, this);
+      if (!network_task_runner->DeleteSoon(FROM_HERE, this)) {
+        // Can't force-delete the object here, because some derived classes

[eroman, 2012/08/15 18:00:44]

Please change the language to not reference chrome concepts (like "IO thread"
and "ShellURLRequestContextGetter").

This may seem silly, but conceptually the net/* directory should be a separable
module with no dependencies on Chrome, even though it is mainly intended to be
embedded into Chrome.

[Andrew T Wilson (Slow), 2012/08/15 18:07:17]

Ah, good point. I'll do this.

+        // (like ShellURLRequestContextGetter) may only be deleted on the IO
+        // thread.
+        DLOG(WARNING) << "URLRequestContextGetter leaking due to no IO thread.";

[eroman, 2012/08/15 18:00:44]

How about making this simply LOG(WARNING)?

[Andrew T Wilson (Slow), 2012/08/15 18:07:17]

Since this really only impacts unit tests, I figured it wasn't worth increasing
the size of the release version of chrome by including a warning.

+      }
     }
   }
   // If no IO message loop proxy was available, we will just leak memory.
   // This is also true if the IO thread is gone.
 }
 
 }  // namespace net