Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 10857: Add OPT=1 flag to build optimized on Linux. (Closed)

Created:
12 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Allow optimized builds on Linux.

Patch Set 1 #

Patch Set 2 : retry #

Patch Set 3 : alles ist gut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M build/SConscript.main View 1 2 3 chunks +21 lines, -11 lines 0 comments Download
M build/SConscript.v8 View 2 2 chunks +14 lines, -3 lines 0 comments Download
A build/using_v8.scons View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 2 chunks +1 line, -1 line 0 comments Download
M net/base/host_resolver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net_perftests.scons View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/dmg_fp/dmg_fp.scons View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/SConscript View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
12 years, 1 month ago (2008-11-12 23:43:50 UTC) #1
sgk
lgtm
12 years, 1 month ago (2008-11-13 01:02:34 UTC) #2
Evan Martin
I rewrote this to work better with the component system. Please look again. I still ...
12 years, 1 month ago (2008-11-13 02:32:51 UTC) #3
Dean McNamee
12 years, 1 month ago (2008-11-13 08:28:18 UTC) #4
Some day we'll have to update the other v8_g's for opt build, but you pointed
out that we don't need to worry about it for now.

LGTM.

On 2008/11/13 02:32:51, Evan Martin wrote:
> I rewrote this to work better with the component system.
> Please look again.
> 
> I still need to figure out what to do with the differing output directories.

Powered by Google App Engine
This is Rietveld 408576698