Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6968)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 10855260: Safe Browsing malware interstitial redesign field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: webui style fixes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 8f19b2d8d524401a8d631716f3f3864b99562e79..b7e8a7587912fa31f5a76e7f85c417d66fb5e6ae 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -1116,9 +1116,11 @@ bool SafeBrowsingService::HandleOneCheck(
void SafeBrowsingService::DoDisplayBlockingPage(
const UnsafeResource& resource) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DVLOG(1) << __FUNCTION__ << " " << resource.url.spec();
arv (Not doing code reviews) 2012/08/22 14:33:45 remove these
mattm 2012/08/22 20:33:47 Done.
// Check if the user has already ignored our warning for this render_view
// and domain.
if (IsWhitelisted(resource)) {
+ DVLOG(1) << "iswhitelisted";
if (!resource.callback.is_null()) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE, base::Bind(resource.callback, true));
@@ -1132,6 +1134,7 @@ void SafeBrowsingService::DoDisplayBlockingPage(
resource.render_view_id);
if (!web_contents) {
+ DVLOG(1) << "tabgone";
// The tab is gone and we did not have a chance at showing the interstitial.
// Just act as if "Don't Proceed" were chosen.
std::vector<UnsafeResource> resources;

Powered by Google App Engine
This is Rietveld 408576698