Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4229)

Unified Diff: chrome/browser/chromeos/gdata/gdata_directory_service.cc

Issue 10855243: child_files_ and child_directories_ have resource_ids instead of GDataFile* and GDataDirectory*. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_directory_service.cc
===================================================================
--- chrome/browser/chromeos/gdata/gdata_directory_service.cc (revision 152309)
+++ chrome/browser/chromeos/gdata/gdata_directory_service.cc (working copy)
@@ -300,7 +300,8 @@
GDataDirectory* current_dir = root_.get();
for (size_t i = 1; i < components.size() && current_dir; ++i) {
- GDataEntry* entry = current_dir->FindChild(components[i]);
+ GDataEntry* entry =
+ GetEntryByResourceId(current_dir->FindChild(components[i]));
satorux1 2012/08/20 16:40:08 looks a bit scary. Maybe: const std::string resou
achuithb 2012/08/20 21:14:57 Done. I've added a DCHECK for entry instead of a r
if (!entry)
return NULL;
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_files.h » ('j') | chrome/browser/chromeos/gdata/gdata_files.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698