linux/clang: Disable the last two warnings, turn on -Werror

net/third_party/nss/ssl.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'conditions': [
     [ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
       'conditions': [
         ['sysroot!=""', {
           'variables': {
@@ skipping 71 matching lines @@
       ],
       'defines!': [
         # Regrettably, NSS can't be compiled with NO_NSPR_10_SUPPORT yet.
         'NO_NSPR_10_SUPPORT',
       ],
       'dependencies': [
         '../../../third_party/zlib/zlib.gyp:zlib',
       ],
       'msvs_disabled_warnings': [4018, 4244],
       'conditions': [
+        [ 'clang == 1', {
+          'cflags': [
+            # See http://crbug.com/138571#c8. In short, sslsecur.c picks up the
+            # system's cert.h because cert.h isn't in chromium's repo.

[Ryan Sleevi, 2012/08/18 01:33:59]

Your comment made it seem like you weren't sure if this was intentional.

It is (at least, on Linux).

If you wanted, you could only set this flag for Linux (or more aptly, match the
inverse of the conditional on line 141), so that any future NSS rolls on
Mac/Win/iOS ensured no further NSS-induced regressions. Since rolling NSS is
something generally done by wtc or myself, it's something we can quickly fix
upstream.

[wtc, 2012/08/18 02:30:07]

It may be better to patch sslsecur.c to cast away the
const, than turning off this warning for all the files
in src/net/third_party/nss/ssl.

+            '-Wno-incompatible-pointer-types',
+          ],
+        }],
         [ 'OS == "mac" or OS == "ios"', {
           'defines': [
             'XP_UNIX',
             'DARWIN',
             'XP_MACOSX',
           ],
         }],
         [ 'OS == "win"', {
             'sources!': [
               'ssl/unix_err.c',
@@ skipping 63 matching lines @@
       'configurations': {
         'Debug_Base': {
           'defines': [
             'DEBUG',
           ],
         },
       },
     },
   ],
 }