[NOT FOR REVIEW] extensions-wm: Add experimental extension API for window management.

extensions-wm: Add experimental extension API for window management.

BUG=143504

[sadrul, 2012-08-17 21:29:00]

Hi! This is a barebone CL to introduce the extensions-wm API. I have added the
implementation for ash in a separate CL in
http://codereview.chromium.org/10824364/ (and there will be subsequent
incremental CLs to introduce API functions).

Please review (and include other reviewers as you see fit). If you think I
should pull in changes from the implementation CL into this one, please let me
know.

http://codereview.chromium.org/10855228/diff/9001/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/10855228/diff/9001/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:332: "extension_types":
["extension", "packaged_app", "platform_app"]
I am not sure about this. So I have included everything here (except
hosted-apps)

[Mihai Parparita -not on Chrome, 2012-08-17 21:45:01]

I'm swamped with apps-related reviews, so I won't be able to do window
management ones. Sorry!

Mihai

[Aaron Boodman, 2012-08-21 21:13:43]

http://codereview.chromium.org/10855228/diff/7025/chrome/app/chromium_strings...
File chrome/app/chromium_strings.grd (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/app/chromium_strings...
chrome/app/chromium_strings.grd:724: Manage all Chromium windows
No warning is necessary for this permission.

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/a...
File chrome/browser/extensions/api/wm/wm_api.h (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/a...
chrome/browser/extensions/api/wm/wm_api.h:5: #ifndef
CHROME_BROWSER_EXTENSIONS_API_WM_WM_API_H_
empty file?

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/a...
chrome/browser/extensions/api/wm/wm_api.h:5: #ifndef
CHROME_BROWSER_EXTENSIONS_API_WM_WM_API_H_
Google C++ style guide discourages abbreviations. In this case, if you just used
window_manager, the paths names and guards would be ridiculous, but you only
have to type those infrequently.

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/e...
File chrome/browser/extensions/event_names.cc (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/e...
chrome/browser/extensions/event_names.cc:73: const char kWmOnWindowCreated[] =
"experimental.wm.onWindowCreated";
Same comment about 'wm'. We should consider just naming this API windows2.

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/e...
File chrome/browser/extensions/event_names.h (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/browser/extensions/e...
chrome/browser/extensions/event_names.h:80: extern const char
kWmOnWindowCreated[];
Are these actually going to be referenced from other places? if not, there's no
need for them to be separate.

http://codereview.chromium.org/10855228/diff/7025/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:331: "channel": "dev",
"trunk" for now.

http://codereview.chromium.org/10855228/diff/7025/chrome/common/extensions/ap...
File chrome/common/extensions/api/experimental_wm.idl (right):

http://codereview.chromium.org/10855228/diff/7025/chrome/common/extensions/ap...
chrome/common/extensions/api/experimental_wm.idl:29: dictionary WmWindow {
s/Wm//

[Aaron Boodman, 2012-09-04 21:37:20]

Ping?