webkit/appcache/appcache_url_request_job.cc - Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_url_request_job.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: NetworkDelegate fixed almost everywhere Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_test_job.cc ('K') | « webkit/appcache/appcache_url_request_job.h ('k') | webkit/appcache/appcache_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/appcache/appcache_url_request_job.cc

diff --git a/webkit/appcache/appcache_url_request_job.cc b/webkit/appcache/appcache_url_request_job.cc

index 2c8efa708fc96123e840098603a2ea0c1ca9ad5f..80c0b7dc1385817ec0434657bc91b41c16468d2c 100644

--- a/webkit/appcache/appcache_url_request_job.cc

+++ b/webkit/appcache/appcache_url_request_job.cc

@@ -18,15 +18,16 @@

#include "net/http/http_response_headers.h"

#include "net/http/http_util.h"

#include "net/url_request/url_request.h"

mmenke 2012/08/21 15:28:49 Not needed?

shalev 2012/08/22 20:34:10 I think this is actually needed, eg. for line 95:

-#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_status.h"

#include "webkit/appcache/appcache_service.h"

namespace appcache {

AppCacheURLRequestJob::AppCacheURLRequestJob(

- net::URLRequest* request, AppCacheStorage* storage)

- : net::URLRequestJob(request, request->context()->network_delegate()),

+ net::URLRequest* request,

+ net::NetworkDelegate* network_delegate,

+ AppCacheStorage* storage)

+ : net::URLRequestJob(request, network_delegate),

storage_(storage),

has_been_started_(false), has_been_killed_(false),

delivery_type_(AWAITING_DELIVERY_ORDERS),

« net/url_request/url_request_test_job.cc ('K') | « webkit/appcache/appcache_url_request_job.h ('k') | webkit/appcache/appcache_url_request_job_unittest.cc » ('j') | no next file with comments »