net/url_request/url_request_simple_job.cc - Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_simple_job.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: NetworkDelegate fixed almost everywhere Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_redirect_job.cc ('K') | « net/url_request/url_request_simple_job.h ('k') | net/url_request/url_request_test_job.h » ('j') | net/url_request/url_request_test_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_simple_job.cc

diff --git a/net/url_request/url_request_simple_job.cc b/net/url_request/url_request_simple_job.cc

index 8ab59f6be7f251bc08f81cd2f8ffbfebe2631c33..73f93ab75835682ab8836a7846dfb8f66b959fc3 100644

--- a/net/url_request/url_request_simple_job.cc

+++ b/net/url_request/url_request_simple_job.cc

@@ -10,13 +10,13 @@

#include "net/base/io_buffer.h"

#include "net/base/net_errors.h"

#include "net/url_request/url_request.h"

mmenke 2012/08/21 15:28:49 Not needed?

shalev 2012/08/22 20:34:10 Done.

-#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_status.h"

namespace net {

-URLRequestSimpleJob::URLRequestSimpleJob(URLRequest* request)

- : URLRequestJob(request, request->context()->network_delegate()),

+URLRequestSimpleJob::URLRequestSimpleJob(

+ URLRequest* request, NetworkDelegate* network_delegate)

+ : URLRequestJob(request, network_delegate),

data_offset_(0),

ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {}