net/url_request/url_request_ftp_job_unittest.cc - Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job_unittest.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: NetworkDelegate fixed almost everywhere Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_file_job.cc ('K') | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/url_request_http_job.h » ('j') | net/url_request/url_request_redirect_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_ftp_job_unittest.cc

diff --git a/net/url_request/url_request_ftp_job_unittest.cc b/net/url_request/url_request_ftp_job_unittest.cc

index d1ad36a55aea914f9aa99b4f3ce8db0dc40a89cb..743daf1fe0af3f78c0a8fd9d2389e11658c2ac69 100644

--- a/net/url_request/url_request_ftp_job_unittest.cc

+++ b/net/url_request/url_request_ftp_job_unittest.cc

@@ -57,10 +57,10 @@ TEST(FtpProtocolHandlerTest, CreateTransactionFails) {

URLRequest url_request(url, &delegate, &context);

FtpProtocolHandler ftp_protocol_handler(

- NULL, &ftp_transaction_factory, &ftp_auth_cache);

+ &ftp_transaction_factory, &ftp_auth_cache);

scoped_refptr<URLRequestJob> ftp_job(

- ftp_protocol_handler.MaybeCreateJob(&url_request));

+ ftp_protocol_handler.MaybeCreateJob(&url_request, NULL));

ASSERT_TRUE(ftp_job.get());

EXPECT_CALL(ftp_transaction_factory, CreateTransaction())