net/url_request/url_request_job_factory.cc - Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_protocols.cc ('K') | « net/url_request/url_request_job_factory.h ('k') | net/url_request/url_request_job_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_job_factory.cc

diff --git a/net/url_request/url_request_job_factory.cc b/net/url_request/url_request_job_factory.cc

index 44bc0024170c3ae68135b5e73ee65839b29fee28..cfdd9ef953d225d6106291bd151ea86ed6c45b3c 100644

--- a/net/url_request/url_request_job_factory.cc

+++ b/net/url_request/url_request_job_factory.cc

@@ -73,12 +73,13 @@ URLRequestJob* URLRequestJobFactory::MaybeCreateJobWithInterceptor(

URLRequestJob* URLRequestJobFactory::MaybeCreateJobWithProtocolHandler(

const std::string& scheme,

- URLRequest* request) const {

+ URLRequest* request,

+ NetworkDelegate* network_delegate) const {

DCHECK(CalledOnValidThread());

ProtocolHandlerMap::const_iterator it = protocol_handler_map_.find(scheme);

if (it == protocol_handler_map_.end())

return NULL;

- return it->second->MaybeCreateJob(request);

+ return it->second->MaybeCreateJob(request, network_delegate);

}

URLRequestJob* URLRequestJobFactory::MaybeInterceptRedirect(