net/url_request/url_request_http_job.cc - Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_protocols.cc ('K') | « net/url_request/url_request_ftp_job_unittest.cc ('k') | net/url_request/url_request_job_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index a4c156975832734b36c52bc02165d61be281b0e0..b599eea6b562d5a9a4ba9e070c9d87507d7bb80c 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -174,7 +174,8 @@ URLRequestJob* URLRequestHttpJob::Factory(URLRequest* request,

if (!request->context()->http_transaction_factory()) {

NOTREACHED() << "requires a valid context";

- return new URLRequestErrorJob(request, ERR_INVALID_ARGUMENT);

+ return new URLRequestErrorJob(

+ request, request->context()->network_delegate(), ERR_INVALID_ARGUMENT);

}

GURL redirect_url;