PRESUBMIT.py - Issue 10855183: Give access to browsers by Profile/HostDesktopType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 10855183: Give access to browsers by Profile/HostDesktopType. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Now Ash and Native desktop types are the same on ChromeOS Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index ac8a719eed171b4c969b46bbf162dff4b28ea556..0ae66e77cb9448e37edc24c1589752e6cfe7a4d9 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -147,15 +147,6 @@ _BANNED_CPP_FUNCTIONS = (

True,

(

- 'browser::FindBrowserWithProfile',

- (

- 'This function is deprecated and we\'re working on removing it. Pass',

- 'more context to get a Browser*, like a WebContents, window, or session',

- 'id. Talk to ben@ or jam@ for more information.',

- ),

- True,

- ),

- (

'browser::FindAnyBrowser',

(

'This function is deprecated and we\'re working on removing it. Pass',

« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »