Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: net/dns/dns_response_unittest.cc

Issue 10855179: [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/dns_response_unittest.cc
diff --git a/net/dns/dns_response_unittest.cc b/net/dns/dns_response_unittest.cc
index bb053bc24bef87795fb699ad7cf8a0d6d52e8183..6ed6f062b5e6693a4ce1b089f797346806d88a65 100644
--- a/net/dns/dns_response_unittest.cc
+++ b/net/dns/dns_response_unittest.cc
@@ -299,7 +299,7 @@ TEST(DnsResponseTest, ParseToAddressList) {
DnsResponse response(t.response_data, t.response_size, t.query_size);
AddressList addr_list;
base::TimeDelta ttl;
- EXPECT_EQ(DnsResponse::DNS_SUCCESS,
+ EXPECT_EQ(DnsResponse::DNS_PARSE_OK,
response.ParseToAddressList(&addr_list, &ttl));
std::vector<const char*> expected_addresses(
t.expected_addresses,
@@ -429,8 +429,9 @@ TEST(DnsResponseTest, ParseToAddressListFail) {
DnsResponse::DNS_CNAME_AFTER_ADDRESS },
{ kResponseTTLMismatch, arraysize(kResponseTTLMismatch),
DnsResponse::DNS_ADDRESS_TTL_MISMATCH },
+ // Not actually a failure, just an empty result.
{ kResponseNoAddresses, arraysize(kResponseNoAddresses),
- DnsResponse::DNS_NO_ADDRESSES },
+ DnsResponse::DNS_PARSE_OK },
};
const size_t kQuerySize = 12 + 7;

Powered by Google App Engine
This is Rietveld 408576698