Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: net/dns/dns_response.cc

Issue 10855179: [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/dns_response.cc
diff --git a/net/dns/dns_response.cc b/net/dns/dns_response.cc
index 4ad6465fbfd8ce8ffc51fa9a312783b0cd23b252..4ab7296701086b5b2cd4555975d0ca7ad67e5984 100644
--- a/net/dns/dns_response.cc
+++ b/net/dns/dns_response.cc
@@ -280,15 +280,13 @@ DnsResponse::Result DnsResponse::ParseToAddressList(
}
// TODO(szym): Extract TTL for NODATA results. http://crbug.com/115051
- if (ip_addresses.empty())
- return DNS_NO_ADDRESSES;
// getcanonname in eglibc returns the first owner name of an A or AAAA RR.
// If the response passed all the checks so far, then |expected_name| is it.
*addr_list = AddressList::CreateFromIPAddressList(ip_addresses,
expected_name);
*ttl = base::TimeDelta::FromSeconds(std::min(cname_ttl_sec, addr_ttl_sec));
- return DNS_SUCCESS;
+ return DNS_PARSE_OK;
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698