Track types for arguments passed to calls to static functions

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1453 matching lines @@
     Selector call = new Selector.call(
         compiler.namer.CLOSURE_INVOCATION_NAME,
         node.selector.library,
         node.selector.argumentCount,
         node.selector.namedArguments);
     world.registerDynamicInvocation(compiler.namer.CLOSURE_INVOCATION_NAME,
                                     call);
   }
 
   visitInvokeStatic(HInvokeStatic node) {
+    if (Elements.isStaticOrTopLevelFunction(node.element) &&
+        node is !HInvokeSuper &&
+        node is !HInvokeInterceptor &&
+        node is !HInvokeBinary &&
+        node is !HInvokeUnary &&
+        node is !HIndex &&
+        node is !HIndexAssign) {
+      // Register this invocation to collect the types used at all call sites.

[floitsch, 2012/08/15 09:11:59]

assert that the typeCode is the one you expect it to be.
I would add a static STATIC_CALL_TYPECODE constant in the HInvokeStatic class,
and use that one in its typeCode and here. You might even want to remove all the
is checks and just use the typeCode.

[Søren Gjesse, 2012/08/15 12:17:10]

Done.

We should look into giving named constants to all type codes. Currently they are
just integer literals.

+      if (Elements.isStaticOrTopLevelFunction(node.element)) {

[floitsch, 2012/08/15 09:11:59]

redundant if.

[Søren Gjesse, 2012/08/15 12:17:10]

Removed.

+        backend.registerStaticInvocation(node);
+      }
+    }
     use(node.target);
     push(new js.Call(pop(), visitArguments(node.inputs)), node);
   }
 
   visitInvokeSuper(HInvokeSuper node) {
     Element superMethod = node.element;
     Element superClass = superMethod.getEnclosingClass();
     // Remove the element and 'this'.
     int argumentCount = node.inputs.length - 2;
     String className = compiler.namer.isolateAccess(superClass);
@@ skipping 399 matching lines @@
     js.Call value = new js.Call(jsHelper, visitArguments([null, argument]));
     attachLocation(value, argument);
     pushStatement(new js.Throw(value));
   }
 
   void visitSwitch(HSwitch node) {
     // Switches are handled using [visitSwitchInfo].
   }
 
   void visitStatic(HStatic node) {
+    node.usedBy.forEach((HInstruction instr) {
+      if (instr is !HInvokeStatic || instr.target !== node) {

[floitsch, 2012/08/15 09:11:59]

not enough:
foo(foo);

[Søren Gjesse, 2012/08/15 12:17:10]

Good catch!

Added check that the HStatic is also not any of the other inputs if is is the
target.

+        backend.registerNonCallStaticUse(node);
+      }
+    });
     world.registerStaticUse(node.element);
     push(new js.VariableUse(compiler.namer.isolateAccess(node.element)));
   }
 
   void visitStaticStore(HStaticStore node) {
     world.registerStaticUse(node.element);
     js.VariableUse variableUse =
         new js.VariableUse(compiler.namer.isolateAccess(node.element));
     use(node.inputs[0]);
     push(new js.Assignment(variableUse, pop()), node);
@@ skipping 954 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }