Update browserAction.setIcon and pageAction.setIcon for hidpi

chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

Index: chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
diff --git a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
index 41609111d986ab0064f455e89ca4a3bef1313d06..8e6d809fb91c0664a917f3925134a5da943087a4 100644
--- a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
+++ b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js
@@ -2,9 +2,29 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+var canvas = document.getElementById("canvas").getContext('2d').
+    getImageData(0, 0, 19, 19);
+var canvasHD = document.getElementById("canvas").getContext('2d').
+    getImageData(0, 0, 38, 38);
+
+var setIconParamQueue = [
+  {imageData: canvas},
+  {path: 'icon.png'},
+  {imageData: {'19': canvas, '38': canvasHD}},
+  {path: {'19': 'icon.png', '38': 'icon.png'}},
+  {imageData: {'19': canvas}},

[Jeffrey Yasskin, 2012/08/21 20:10:38]

Would it be a good test to check only setting a 2x icon? There's probably no
need to do it for both imageData and path; your other tests cover that
conversion.

Another possible test would be passing an empty dictionary to imageData or path
and checking that it throws a reasonable exception.

[tbarzic, 2012/08/22 00:12:49]

Done.

+  {path: {'19': 'icon.png'}},
+];
+
 // Called when the user clicks on the browser action.
 chrome.browserAction.onClicked.addListener(function(windowId) {
-  chrome.tabs.executeScript(null, {code:"document.body.bgColor='red'"});
+  if (setIconParamQueue.length == 0) {
+    chrome.test.notifyFail("Queue of params for test cases unexpectedly empty");
+    return;
+  }
+
+  chrome.browserAction.setIcon(setIconParamQueue.shift(), function() {
+    chrome.test.notifyPass();});
 });
 
 chrome.test.notifyPass();