chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js - Issue 10855154: Update browserAction.setIcon and pageAction.setIcon for hidpi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js

Issue 10855154: Update browserAction.setIcon and pageAction.setIcon for hidpi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js

diff --git a/chrome/test/data/extensions/api_test/page_action/old_api/page.js b/chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js

similarity index 70%

copy from chrome/test/data/extensions/api_test/page_action/old_api/page.js

copy to chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js

index de7b8ae5f692adf74d6f691dbb50b6c4c974e594..01e0a25df7a97b3d12661279cab028e8dfb65e35 100644

--- a/chrome/test/data/extensions/api_test/page_action/old_api/page.js

+++ b/chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.js

@@ -4,6 +4,7 @@

// Enable the page action on this tab.

chrome.tabs.getSelected(null, function(tab) {

- chrome.pageActions.enableForTab("action", {"tabId":tab.id, "url":tab.url});

- chrome.test.notifyPass();

+ chrome.pageAction.setIcon({tabId: tab.id, iconIndex: 1}, function(){

+ chrome.test.notifyPass();

+ });

});

« no previous file with comments | « chrome/test/data/extensions/api_test/page_action/old_api/set_icon_index.html ('k') | no next file » | no next file with comments »