chrome/test/data/extensions/api_test/browser_action/no_icon/background.html - Issue 10855154: Update browserAction.setIcon and pageAction.setIcon for hidpi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/no_icon/background.html

Issue 10855154: Update browserAction.setIcon and pageAction.setIcon for hidpi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/set_icon.js ('K') | « chrome/renderer/resources/extensions/set_icon.js ('k') | chrome/test/data/extensions/api_test/browser_action/no_icon/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/no_icon/background.html

diff --git a/chrome/test/data/extensions/api_test/page_action/old_api/background.html b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html

similarity index 80%

copy from chrome/test/data/extensions/api_test/page_action/old_api/background.html

copy to chrome/test/data/extensions/api_test/browser_action/no_icon/background.html

index f4b25c8e1055f5faff108fda866719ac7fd9fb13..0dd0265556f2662c35d0532cd7670f55f6562a45 100644

--- a/chrome/test/data/extensions/api_test/page_action/old_api/background.html

+++ b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.html

@@ -5,6 +5,9 @@

-->

<html>

<head>

-<script src="background.js"></script>

</head>

+<body>

+<canvas id="canvas" width="37" height="33">

Jeffrey Yasskin 2012/08/17 23:20:28 Why these dimensions?

tbarzic 2012/08/21 00:22:07 no particular reason, they're pretty random

+<script src="background.js"></script>

+</body>

</html>