Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 10855135: Fix DownloadsDOMHandler::OnDownloadDestroyed (Closed)

Created:
8 years, 4 months ago by benjhayden
Modified:
8 years, 4 months ago
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays), kareng
Visibility:
Public.

Description

Fix DownloadsDOMHandler::OnDownloadDestroyed() to not set *vector::end() = NULL. DownloadsDOMHandler::download_items_ does not always contain all of the items that it observes, so std::find may return end(). I have no idea what happens when you set *end()=NULL, but it could explain the crash in DownloadsDOMHandler::ClearDownloadItems() on windows, somewhere in "for (OrderedDownloads::iterator it = download_items_.begin(); it != download_items_.end(); ++it)". BUG=142389 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
benjhayden
PTAL
8 years, 4 months ago (2012-08-13 21:27:30 UTC) #1
Randy Smith (Not in Mondays)
LGTM.
8 years, 4 months ago (2012-08-13 21:39:58 UTC) #2
benjhayden
Just need OWNERShip review from either James or Evan, then I'll hit the CQ and ...
8 years, 4 months ago (2012-08-13 21:47:06 UTC) #3
benjhayden
+Karen
8 years, 4 months ago (2012-08-13 21:47:35 UTC) #4
James Hawkins
Please provide a better CL description before committing. LGTM
8 years, 4 months ago (2012-08-13 21:52:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10855135/1
8 years, 4 months ago (2012-08-13 22:01:43 UTC) #6
benjhayden
On 2012/08/13 21:52:51, James Hawkins wrote: > Please provide a better CL description before committing. ...
8 years, 4 months ago (2012-08-13 22:02:29 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 23:30:26 UTC) #8
Try job failure for 10855135-1 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698