chrome/common/extensions/csp_validator.cc - Issue 10855122: Whitelisting `127.0.0.1` and `localhost` for HTTP in extensions' CSP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/csp_validator.cc

Issue 10855122: Whitelisting `127.0.0.1` and `localhost` for HTTP in extensions' CSP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Less stupid patch. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/csp_validator.cc

diff --git a/chrome/common/extensions/csp_validator.cc b/chrome/common/extensions/csp_validator.cc

index a57bdb0ce9bbb3288d744dcf2c7da383d015ea7b..225fbd726715ceedf88d02c12d8da3724a6f454d 100644

--- a/chrome/common/extensions/csp_validator.cc

+++ b/chrome/common/extensions/csp_validator.cc

@@ -46,6 +46,8 @@ bool HasOnlySecureTokens(StringTokenizer& tokenizer) {

// We might need to relax this whitelist over time.

if (source == "'self'" ||

source == "'none'" ||

+ source == "http://127.0.0.1" ||

+ source == "http://localhost" ||

abarth-chromium 2012/08/13 15:50:01 This one should probably be case insensitive.

abarth-chromium 2012/08/13 15:50:42 Do we want to allow non-default ports? You might

StartsWithASCII(source, "https://", true) ||

StartsWithASCII(source, "chrome://", true) ||

StartsWithASCII(source, "chrome-extension://", true) ||

« no previous file with comments | « no previous file | chrome/common/extensions/csp_validator_unittest.cc » ('j') | no next file with comments »