Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 10855111: libwebp: silence libtool warning on non-neon builds (Closed)

Created:
8 years, 4 months ago by jzern
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

libwebp: silence libtool warning on non-neon builds BUG=141949 TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151196

Patch Set 1 #

Total comments: 2

Patch Set 2 : hide more things under armv7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/libwebp/libwebp.gyp View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jzern
Mac build log doesn't seem to have the warning anymore, any other bots to run?
8 years, 4 months ago (2012-08-10 22:09:28 UTC) #1
Nico
LGTM One optional nit below. Thank you for taking care of this so quickly! http://codereview.chromium.org/10855111/diff/1/third_party/libwebp/libwebp.gyp ...
8 years, 4 months ago (2012-08-10 23:14:33 UTC) #2
jzern
http://codereview.chromium.org/10855111/diff/1/third_party/libwebp/libwebp.gyp File third_party/libwebp/libwebp.gyp (right): http://codereview.chromium.org/10855111/diff/1/third_party/libwebp/libwebp.gyp#newcode74 third_party/libwebp/libwebp.gyp:74: 'type': 'none', On 2012/08/10 23:14:33, Nico wrote: > nit: ...
8 years, 4 months ago (2012-08-11 02:07:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/10855111/2002
8 years, 4 months ago (2012-08-11 03:23:18 UTC) #4
commit-bot: I haz the power
Try job failure for 10855111-2002 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-11 05:06:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/10855111/2002
8 years, 4 months ago (2012-08-11 17:36:44 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 02:29:20 UTC) #7
Change committed as 151196

Powered by Google App Engine
This is Rietveld 408576698