Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: media/audio/audio_manager_base.cc

Issue 10855086: Disable AudioOutputMixer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/audio_output_mixer.h » ('j') | media/audio/audio_output_mixer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 444a41532e9f1c819185d49ff540d25c0e9ddd79..5ea4c236e563f57901bbcda7407ab548678abfb7 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -9,7 +9,8 @@
#include "base/message_loop_proxy.h"
#include "base/threading/thread.h"
#include "media/audio/audio_output_dispatcher_impl.h"
-#include "media/audio/audio_output_mixer.h"
+// TODO(dalecurtis): Temporarily disabled while switching over to floats.
+// #include "media/audio/audio_output_mixer.h"
scherkus (not reviewing) 2012/08/09 22:12:39 this is better handled via an #ifdef i.e., after
DaleCurtis 2012/08/09 22:46:29 Done.
#include "media/audio/audio_output_proxy.h"
#include "media/audio/fake_audio_input_stream.h"
#include "media/audio/fake_audio_output_stream.h"
@@ -142,15 +143,15 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStreamProxy(
if (!dispatcher) {
base::TimeDelta close_delay =
base::TimeDelta::FromSeconds(kStreamCloseDelaySeconds);
- const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
+ // TODO(dalecurtis): Temporarily disabled while switching over to floats.
scherkus (not reviewing) 2012/08/09 22:12:39 link to bug?
DaleCurtis 2012/08/09 22:46:29 Done.
// TODO(dalecurtis): Browser side mixing has a couple issues that must be
// fixed before it can be turned on by default: http://crbug.com/138098 and
// http://crbug.com/140247
- if (cmd_line->HasSwitch(switches::kEnableAudioMixer)) {
- dispatcher = new AudioOutputMixer(this, params, close_delay);
- } else {
- dispatcher = new AudioOutputDispatcherImpl(this, params, close_delay);
- }
+ // const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
+ // if (cmd_line->HasSwitch(switches::kEnableAudioMixer))
+ // dispatcher = new AudioOutputMixer(this, params, close_delay);
+ // else
+ dispatcher = new AudioOutputDispatcherImpl(this, params, close_delay);
}
return new AudioOutputProxy(dispatcher);
}
« no previous file with comments | « no previous file | media/audio/audio_output_mixer.h » ('j') | media/audio/audio_output_mixer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698