Fix Ash notification updates

Fix Ash notification updates

In Chrome, it turns out that every Notification has a unique id. In the Ash implementation we need to track and update that id when an existing Bubble is updated.

This also ensures that the UI is safely created initially (in case the initial asynchronous Update is delayed) to prevent crashes and to make Layout more consistent.

Also includes some cleanup of the WebNotificationTray API.

BUG=141285
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150979

[sadrul, 2012-08-09 18:14:44]

LGTM with a comment:

http://codereview.chromium.org/10855079/diff/1/ash/system/web_notification/we...
File ash/system/web_notification/web_notification_tray.cc (right):

http://codereview.chromium.org/10855079/diff/1/ash/system/web_notification/we...
ash/system/web_notification/web_notification_tray.cc:150: notification.id =
new_id;
In AddNotification, any existing notifications with the same id is removed.
Should the same be done for |new_id| here?

[stevenjb, 2012-08-09 19:05:05]

Updated code and updated tests.
+sky for chrome/browser/ui/views/ash/ OWNERS 
PTAL

http://codereview.chromium.org/10855079/diff/1/ash/system/web_notification/we...
File ash/system/web_notification/web_notification_tray.cc (right):

http://codereview.chromium.org/10855079/diff/1/ash/system/web_notification/we...
ash/system/web_notification/web_notification_tray.cc:150: notification.id =
new_id;
On 2012/08/09 18:14:45, sadrul wrote:
> In AddNotification, any existing notifications with the same id is removed.
> Should the same be done for |new_id| here?
Good catch. Moved the duplicate check to PushNotification. (In practice this
shouldn't ever happen, but it is good to be robust and consistent).

[stevenjb, 2012-08-09 19:05:21]

+sky for chrome/browser/ui/views/ash/ OWNERS

[sky, 2012-08-09 19:47:25]

LGTM

[commit-bot: I haz the power, 2012-08-10 01:01:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10855079/9001

[commit-bot: I haz the power, 2012-08-10 02:43:46]

Change committed as 150979