Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5084)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_model.h

Issue 10855066: intents: Remove the disposition enum in web intents model. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_model.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_model.h b/chrome/browser/ui/intents/web_intent_picker_model.h
index 4c6504dc52cbb103097a4f20c577503563c9166f..62a37c67ca6fb967dae62e064f804a848ab726a7 100644
--- a/chrome/browser/ui/intents/web_intent_picker_model.h
+++ b/chrome/browser/ui/intents/web_intent_picker_model.h
@@ -10,6 +10,7 @@
#include "base/string16.h"
#include "googleurl/src/gurl.h"
#include "ui/gfx/image/image.h"
+#include "webkit/glue/web_intent_service_data.h"
class WebIntentPickerModelObserver;
@@ -20,18 +21,12 @@ class Image;
// Model for the WebIntentPicker.
class WebIntentPickerModel {
public:
- // The intent service disposition.
- // TODO(gbillock): use the webkit_glue::WebIntentServiceData::Disposition
- enum Disposition {
- DISPOSITION_WINDOW, // Display the intent service in a new window.
- DISPOSITION_INLINE, // Display the intent service in the picker.
- };
-
// An intent service to display in the picker.
struct InstalledService {
- InstalledService(const string16& title,
- const GURL& url,
- Disposition disposition);
+ InstalledService(
+ const string16& title,
+ const GURL& url,
+ webkit_glue::WebIntentServiceData::Disposition disposition);
~InstalledService();
// The title of this service.
@@ -44,7 +39,7 @@ class WebIntentPickerModel {
gfx::Image favicon;
// The disposition to use when displaying this service.
- Disposition disposition;
+ webkit_glue::WebIntentServiceData::Disposition disposition;
};
// A suggested extension to display in the picker.
@@ -90,9 +85,10 @@ class WebIntentPickerModel {
// Add a new installed service with |title|, |url| and |disposition| to the
// picker.
- void AddInstalledService(const string16& title,
- const GURL& url,
- Disposition disposition);
+ void AddInstalledService(
+ const string16& title,
+ const GURL& url,
+ webkit_glue::WebIntentServiceData::Disposition disposition);
// Remove an installed service from the picker at |index|.
void RemoveInstalledServiceAt(size_t index);

Powered by Google App Engine
This is Rietveld 408576698