Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 10855066: intents: Remove the disposition enum in web intents model. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mock type. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
index 1cf4e48d020e53e99e23d24c2b7604853528646b..65cf5383b3cf7fed40b72aaa33cca911a03bb37b 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
@@ -200,8 +200,6 @@ class IntentsDispatcherMock : public content::WebIntentsDispatcher {
class WebIntentPickerControllerBrowserTest : public InProcessBrowserTest {
protected:
- typedef WebIntentPickerModel::Disposition Disposition;
-
WebIntentPickerControllerBrowserTest() {}
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
@@ -306,7 +304,9 @@ class WebIntentPickerControllerBrowserTest : public InProcessBrowserTest {
controller_->OnSendReturnMessage(reply_type);
}
- void OnServiceChosen(const GURL& url, Disposition disposition) {
+ void OnServiceChosen(
+ const GURL& url,
+ webkit_glue::WebIntentServiceData::Disposition disposition) {
controller_->OnServiceChosen(url, disposition);
}
@@ -353,7 +353,8 @@ IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest, ChooseService) {
IntentsDispatcherMock dispatcher(intent);
controller_->SetIntentsDispatcher(&dispatcher);
- OnServiceChosen(kServiceURL2, WebIntentPickerModel::DISPOSITION_WINDOW);
+ OnServiceChosen(kServiceURL2,
+ webkit_glue::WebIntentServiceData::DISPOSITION_WINDOW);
ASSERT_EQ(2, browser()->tab_count());
EXPECT_EQ(GURL(kServiceURL2),
chrome::GetActiveWebContents(browser())->GetURL());
@@ -417,7 +418,8 @@ IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest,
IntentsDispatcherMock dispatcher(intent);
controller_->SetIntentsDispatcher(&dispatcher);
- OnServiceChosen(kServiceURL1, WebIntentPickerModel::DISPOSITION_WINDOW);
+ OnServiceChosen(kServiceURL1,
+ webkit_glue::WebIntentServiceData::DISPOSITION_WINDOW);
ASSERT_EQ(3, browser()->tab_count());
EXPECT_EQ(GURL(kServiceURL1),
chrome::GetActiveWebContents(browser())->GetURL());
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/intents/web_intent_picker_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698