Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: media/filters/ffmpeg_video_decoder.cc

Issue 10855051: Use enum instead of string in MessageLoopFactory::GetMessageLoop* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolve comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_video_decoder.cc
diff --git a/media/filters/ffmpeg_video_decoder.cc b/media/filters/ffmpeg_video_decoder.cc
index 32aff946b3f07f9e5af4d735ee76b9cbb55e7452..7daffaec0e259f514c7bc1fa2c3c129d48947adc 100644
--- a/media/filters/ffmpeg_video_decoder.cc
+++ b/media/filters/ffmpeg_video_decoder.cc
@@ -10,7 +10,8 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/command_line.h"
-#include "base/message_loop.h"
+#include "base/location.h"
+#include "base/message_loop_proxy.h"
#include "base/string_number_conversions.h"
#include "media/base/decoder_buffer.h"
#include "media/base/demuxer_stream.h"
@@ -53,9 +54,8 @@ static int GetThreadCount(CodecID codec_id) {
return decode_threads;
}
-FFmpegVideoDecoder::FFmpegVideoDecoder(
- const base::Callback<MessageLoop*()>& message_loop_cb,
- Decryptor* decryptor)
+FFmpegVideoDecoder::FFmpegVideoDecoder(const MessageLoopCB& message_loop_cb,
+ Decryptor* decryptor)
: message_loop_factory_cb_(message_loop_cb),
message_loop_(NULL),
state_(kUninitialized),
@@ -139,16 +139,14 @@ void FFmpegVideoDecoder::Initialize(const scoped_refptr<DemuxerStream>& stream,
FFmpegGlue::GetInstance();
if (!message_loop_) {
- message_loop_ = message_loop_factory_cb_.Run();
- message_loop_factory_cb_.Reset();
-
+ message_loop_ = base::ResetAndReturn(&message_loop_factory_cb_).Run();
message_loop_->PostTask(FROM_HERE, base::Bind(
&FFmpegVideoDecoder::Initialize, this,
stream, status_cb, statistics_cb));
return;
}
- DCHECK_EQ(MessageLoop::current(), message_loop_);
+ DCHECK(message_loop_->BelongsToCurrentThread());
DCHECK(!demuxer_stream_);
if (!stream) {
@@ -208,7 +206,7 @@ void FFmpegVideoDecoder::Read(const ReadCB& read_cb) {
}
void FFmpegVideoDecoder::Reset(const base::Closure& closure) {
- if (MessageLoop::current() != message_loop_) {
+ if (!message_loop_->BelongsToCurrentThread()) {
message_loop_->PostTask(FROM_HERE, base::Bind(
&FFmpegVideoDecoder::Reset, this, closure));
return;
@@ -233,7 +231,7 @@ void FFmpegVideoDecoder::DoReset() {
}
void FFmpegVideoDecoder::Stop(const base::Closure& closure) {
- if (MessageLoop::current() != message_loop_) {
+ if (!message_loop_->BelongsToCurrentThread()) {
message_loop_->PostTask(FROM_HERE, base::Bind(
&FFmpegVideoDecoder::Stop, this, closure));
return;
@@ -262,7 +260,7 @@ FFmpegVideoDecoder::~FFmpegVideoDecoder() {
}
void FFmpegVideoDecoder::DoRead(const ReadCB& read_cb) {
- DCHECK_EQ(MessageLoop::current(), message_loop_);
+ DCHECK(message_loop_->BelongsToCurrentThread());
DCHECK(!read_cb.is_null());
CHECK(read_cb_.is_null()) << "Overlapping decodes are not supported.";
@@ -304,7 +302,7 @@ void FFmpegVideoDecoder::DecryptOrDecodeBuffer(
void FFmpegVideoDecoder::DoDecryptOrDecodeBuffer(
DemuxerStream::Status status,
const scoped_refptr<DecoderBuffer>& buffer) {
- DCHECK_EQ(MessageLoop::current(), message_loop_);
+ DCHECK(message_loop_->BelongsToCurrentThread());
DCHECK_NE(state_, kUninitialized);
DCHECK_NE(state_, kDecodeFinished);
DCHECK(!read_cb_.is_null());
@@ -349,7 +347,7 @@ void FFmpegVideoDecoder::BufferDecrypted(
void FFmpegVideoDecoder::DoBufferDecrypted(
Decryptor::Status decrypt_status,
const scoped_refptr<DecoderBuffer>& buffer) {
- DCHECK_EQ(MessageLoop::current(), message_loop_);
+ DCHECK(message_loop_->BelongsToCurrentThread());
DCHECK_NE(state_, kUninitialized);
DCHECK_NE(state_, kDecodeFinished);
DCHECK(!read_cb_.is_null());
@@ -376,7 +374,7 @@ void FFmpegVideoDecoder::DoBufferDecrypted(
void FFmpegVideoDecoder::DecodeBuffer(
const scoped_refptr<DecoderBuffer>& buffer) {
- DCHECK_EQ(MessageLoop::current(), message_loop_);
+ DCHECK(message_loop_->BelongsToCurrentThread());
DCHECK_NE(state_, kUninitialized);
DCHECK_NE(state_, kDecodeFinished);
DCHECK(reset_cb_.is_null());

Powered by Google App Engine
This is Rietveld 408576698