Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10855051: Use enum instead of string in MessageLoopFactory::GetMessageLoop* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolve comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 3c1526682498c7356cdf5601f31cba94d9534be8..054bb2db8ef978fcef4b3807bbf2a0e25ac61bee 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -15,6 +15,7 @@
#include "base/compiler_specific.h"
#include "base/json/json_writer.h"
#include "base/lazy_instance.h"
+#include "base/message_loop_proxy.h"
#include "base/metrics/histogram.h"
#include "base/path_service.h"
#include "base/process_util.h"
@@ -2416,16 +2417,18 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
RenderThreadImpl::current()->GetGpuVDAContext3D() :
base::WeakPtr<WebGraphicsContext3DCommandBufferImpl>();
if (context3d) {
- MessageLoop* factories_loop =
+ scoped_refptr<base::MessageLoopProxy> factories_loop =
RenderThreadImpl::current()->compositor_thread() ?
RenderThreadImpl::current()->compositor_thread()->GetWebThread()
- ->message_loop() :
- MessageLoop::current();
+ ->message_loop()->message_loop_proxy() :
+ base::MessageLoopProxy::current();
GpuChannelHost* gpu_channel_host =
RenderThreadImpl::current()->EstablishGpuChannelSync(
content::CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
collection->AddVideoDecoder(new media::GpuVideoDecoder(
- message_loop_factory->GetMessageLoop("GpuVideoDecoder"),
+ base::Bind(&media::MessageLoopFactory::GetMessageLoop,
+ base::Unretained(message_loop_factory),
+ media::MessageLoopFactory::kVideoDecoder),
factories_loop,
new RendererGpuVideoDecoderFactories(
gpu_channel_host, factories_loop, context3d)));

Powered by Google App Engine
This is Rietveld 408576698