Use enum instead of string in MessageLoopFactory::GetMessageLoop*

media/base/message_loop_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/message_loop_factory.h"
 
 #include "base/threading/thread.h"
 
 namespace media {
 
 MessageLoopFactory::MessageLoopFactory() {}
 
 MessageLoopFactory::~MessageLoopFactory() {
   for (ThreadList::reverse_iterator it = threads_.rbegin();
        it != threads_.rend(); ++it) {
     base::Thread* thread = it->second;
     thread->Stop();
     delete thread;
   }
   threads_.clear();
 }
 
-MessageLoop* MessageLoopFactory::GetMessageLoop(const std::string& name) {
-  return GetThread(name)->message_loop();
+scoped_refptr<base::MessageLoopProxy> MessageLoopFactory::GetMessageLoop(
+    Type type) {
+  return GetThread(type)->message_loop_proxy();
 }
 
-scoped_refptr<base::MessageLoopProxy>
-MessageLoopFactory::GetMessageLoopProxy(const std::string& name) {
-  return GetThread(name)->message_loop_proxy();
-}
-
-base::Thread* MessageLoopFactory::GetThread(const std::string& name) {
-  DCHECK(!name.empty());
-
+base::Thread* MessageLoopFactory::GetThread(Type type) {
   base::AutoLock auto_lock(lock_);
   for (ThreadList::iterator it = threads_.begin(); it != threads_.end(); ++it) {
-    if (it->first == name)
+    if (it->first == type)
       return it->second;
   }
 
-  base::Thread* thread = new base::Thread(name.c_str());
+  const char* name = NULL;
+  switch (type) {
+    case kAudioDecoder:
+      name = "AudioDecoderThread";
+      break;
+    case kVideoDecoder:
+      name = "VideoDecoderThread";
+      break;
+    case kPipeline:
+      name = "PipelineThread";
+      break;
+  }
+
+  base::Thread* thread = new base::Thread(name);
   CHECK(thread->Start()) << "Failed to start thread: " << name;
-  threads_.push_back(std::make_pair(name, thread));
+  threads_.push_back(std::make_pair(type, thread));
   return thread;
 }
 
 }  // namespace media