Use enum instead of string in MessageLoopFactory::GetMessageLoop*

media/base/pipeline.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/pipeline.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 48 matching lines @@
   base::AutoLock auto_lock(lock_);
   DCHECK(notified_);
   return status_;
 }
 
 struct Pipeline::PipelineInitState {
   scoped_refptr<AudioDecoder> audio_decoder;
   scoped_refptr<VideoDecoder> video_decoder;
 };
 
-Pipeline::Pipeline(MessageLoop* message_loop, MediaLog* media_log)
-    : message_loop_(message_loop->message_loop_proxy()),
+Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
+                   MediaLog* media_log)
+    : message_loop_(message_loop),
       media_log_(media_log),
       running_(false),
       seek_pending_(false),
       stop_pending_(false),
       tearing_down_(false),
       error_caused_teardown_(false),
       playback_rate_change_pending_(false),
       did_loading_progress_(false),
       total_bytes_(0),
       natural_size_(0, 0),
@@ skipping 458 matching lines @@
   // Continue the initialize task by proceeding to the next stage.
   message_loop_->PostTask(FROM_HERE, base::Bind(
       &Pipeline::InitializeTask, this, status));
 }
 
 // Called from any thread.
 // This method makes the PipelineStatusCB behave like a Closure. It
 // makes it look like a host()->SetError() call followed by a call to
 // OnFilterStateTransition() when errors occur.
 //
-// TODO: Revisit this code when SetError() is removed from FilterHost and
-//       all the Closures are converted to PipelineStatusCB.
+// TODO(scherkus): Revisit this code when SetError() is removed from FilterHost
+//                 and all the Closures are converted to PipelineStatusCB.

[scherkus (not reviewing), 2012/08/10 17:00:09]

don't indent -- people with long ldaps get cheated on usable whitespace!

[xhwang, 2012/08/10 19:33:33]

Done.

 void Pipeline::OnFilterStateTransition(PipelineStatus status) {
   if (status != PIPELINE_OK)
     SetError(status);
   message_loop_->PostTask(FROM_HERE, base::Bind(
       &Pipeline::FilterStateTransitionTask, this));
 }
 
 void Pipeline::OnTeardownStateTransition(PipelineStatus status) {
   // Ignore any errors during teardown.
   message_loop_->PostTask(FROM_HERE, base::Bind(
@@ skipping 715 matching lines @@
 void Pipeline::StartClockIfWaitingForTimeUpdate_Locked() {
   lock_.AssertAcquired();
   if (!waiting_for_clock_update_)
     return;
 
   waiting_for_clock_update_ = false;
   clock_->Play();
 }
 
 }  // namespace media