Fix extension link error on Android.

Fix extension link error on Android.

The USB extension binding code introduced in r134423 is excluded from
the build when OS==android, but still calls the excluded code. None of
the other bindings are excluded on Android currently, and the files do
actually build, so just reinclude them for now. More extension code may
be excluded from android in future, but in a less piecemeal way.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151081

[Torne, 2012-08-08 10:55:42]

Hi Garret, Antony (original reviewer),

This is a fix for http://codereview.chromium.org/10224009 which breaks building
on Android for some future build targets. Is ifdef'ing it here okay with you
guys, or is there a more elegant way to do this?

[asargent_no_longer_on_chrome, 2012-08-08 18:44:21]

https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
File chrome/renderer/extensions/dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
chrome/renderer/extensions/dispatcher.cc:600: #endif
This seems like kind of a strange place to do this restriction. All that the
ExperimentalUsbCustomBindings module does is provide for unique event id's,
similarly to several of the other bindings files listed here that you haven't
ifdef'ed out (ContextMenusCustomBindings, etc.)

Would it not work to just ifdef out the relevant parts of the USB API
implementation in chrome/browser/extensions/api/usb/?

[joth, 2012-08-09 03:10:48]

On 2012/08/08 18:44:21, Antony Sargent wrote:
>
https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
> File chrome/renderer/extensions/dispatcher.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
> chrome/renderer/extensions/dispatcher.cc:600: #endif
> This seems like kind of a strange place to do this restriction. All that the
> ExperimentalUsbCustomBindings module does is provide for unique event id's,
> similarly to several of the other bindings files listed here that you haven't
> ifdef'ed out (ContextMenusCustomBindings, etc.)
> 
> Would it not work to just ifdef out the relevant parts of the USB API
> implementation in chrome/browser/extensions/api/usb/?

what wasn't clear was why
http://codereview.chromium.org/10224009/diff/33005/chrome/chrome_renderer.gypi
removed the usb_custom_bindings.cc file on android, when indeed none of the
other binding files had to?

Maybe that gypi filter could be removed and this ifdef avoided?

[Torne, 2012-08-09 10:20:57]

On 2012/08/09 03:10:48, joth wrote:
> On 2012/08/08 18:44:21, Antony Sargent wrote:
> >
>
https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
> > File chrome/renderer/extensions/dispatcher.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10855047/diff/1/chrome/renderer/extens...
> > chrome/renderer/extensions/dispatcher.cc:600: #endif
> > This seems like kind of a strange place to do this restriction. All that the
> > ExperimentalUsbCustomBindings module does is provide for unique event id's,
> > similarly to several of the other bindings files listed here that you
haven't
> > ifdef'ed out (ContextMenusCustomBindings, etc.)
> > 
> > Would it not work to just ifdef out the relevant parts of the USB API
> > implementation in chrome/browser/extensions/api/usb/?
> 
> what wasn't clear was why
> http://codereview.chromium.org/10224009/diff/33005/chrome/chrome_renderer.gypi
> removed the usb_custom_bindings.cc file on android, when indeed none of the
> other binding files had to?
> 
> Maybe that gypi filter could be removed and this ifdef avoided?

I put in the ifdef because Garret specifically excluded the files, but I just
tried un-excluding the files and they do compile on Android, so I'm not sure
what the original reason for excluding them was. Garret, do you remember?

[Torne, 2012-08-10 13:04:39]

OK, I experimented with this and the excluded files appear to compile on Android
anyway, so it probably is better to just re-add them for now.

[asargent_no_longer_on_chrome, 2012-08-10 16:25:06]

LGTM

[commit-bot: I haz the power, 2012-08-10 16:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/10855047/1003

[commit-bot: I haz the power, 2012-08-10 16:32:16]

Presubmit check for 10855047-1003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[Nico, 2012-08-10 16:37:21]

lgtm stamp

[commit-bot: I haz the power, 2012-08-10 16:37:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/10855047/1003

[commit-bot: I haz the power, 2012-08-10 17:55:07]

Change committed as 151081