Issue 10855041: Remove Pipeline::kEnded state as it is redundant with Pipeline::kStarted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855041: Remove Pipeline::kEnded state as it is redundant with Pipeline::kStarted. (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)

Modified:
8 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove Pipeline::kEnded state as it is redundant with Pipeline::kStarted. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150591

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -13 lines)			Patch
M	media/base/media_log.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/base/pipeline.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	media/base/pipeline.cc	View	6 chunks	+2 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

split off from http://codereview.chromium.org/10828045/

8 years, 4 months ago (2012-08-08 01:20:23 UTC) #1

acolwell GONE FROM CHROMIUM

LGTM % question http://codereview.chromium.org/10855041/diff/1/media/base/pipeline.cc File media/base/pipeline.cc (right): http://codereview.chromium.org/10855041/diff/1/media/base/pipeline.cc#newcode832 media/base/pipeline.cc:832: if (state_ != kStarted) { Looks ...

8 years, 4 months ago (2012-08-08 17:27:08 UTC) #2

scherkus (not reviewing)

8 years, 4 months ago (2012-08-08 17:34:31 UTC) #3

http://codereview.chromium.org/10855041/diff/1/media/base/pipeline.cc
File media/base/pipeline.cc (right):

http://codereview.chromium.org/10855041/diff/1/media/base/pipeline.cc#newcode832
media/base/pipeline.cc:832: if (state_ != kStarted) {
On 2012/08/08 17:27:08, acolwell wrote:
> Looks like we won't be protected from extra ended calls now. I'm assuming
that's
> ok since it would be a bug. How would we detect it now though?

Chatted offline -- it seems like that was the only use for kEnded. We could add
a bool or something but it's not really worth it for catching renderers that
fire extra ended cbs

Expand Messages | Collapse Messages