Filter unnecessary GestureFlingCancel events.

content/browser/renderer_host/render_widget_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/shared_memory.h"
 #include "base/timer.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/browser/renderer_host/backing_store.h"
@@ skipping 206 matching lines @@
   }
 
   // Allow poking at a few private members.
   using RenderWidgetHostImpl::OnMsgPaintAtSizeAck;
   using RenderWidgetHostImpl::OnMsgUpdateRect;
   using RenderWidgetHostImpl::RendererExited;
   using RenderWidgetHostImpl::in_flight_size_;
   using RenderWidgetHostImpl::is_hidden_;
   using RenderWidgetHostImpl::resize_ack_pending_;
   using RenderWidgetHostImpl::coalesced_gesture_events_;
+  using RenderWidgetHostImpl::fling_in_progress_;
 
   bool unresponsive_timer_fired() const {
     return unresponsive_timer_fired_;
   }
 
   void set_hung_renderer_delay_ms(int delay_ms) {
     hung_renderer_delay_ms_ = delay_ms;
   }
 
  protected:
@@ skipping 610 matching lines @@
   EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(
               ViewMsg_HandleInputEvent::ID));
   process_->sink().ClearMessages();
 
   // After the final ack, the queue should be empty.
   SendInputEventACK(WebInputEvent::GestureScrollEnd, true);
   MessageLoop::current()->RunAllPending();
   EXPECT_EQ(0U, process_->sink().message_count());
 }
 
+// HERE
+TEST_F(RenderWidgetHostTest, GestureFlingCancelsFiltered) {
+  process_->sink().ClearMessages();
+  // GFC without previous GFS is dropped.
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  EXPECT_EQ(0U, process_->sink().message_count());
+  EXPECT_EQ(0U, host_->coalesced_gesture_events_.size());
+
+  // GFC after previous GFS is dispatched and acked.
+  process_->sink().ClearMessages();
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingStart);
+  EXPECT_TRUE(host_->fling_in_progress_);
+  SendInputEventACK(WebInputEvent::GestureFlingStart, true);
+  MessageLoop::current()->RunAllPending();
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(2U, process_->sink().message_count());
+  SendInputEventACK(WebInputEvent::GestureFlingCancel, true);
+  MessageLoop::current()->RunAllPending();
+  EXPECT_EQ(0U, host_->coalesced_gesture_events_.size());
+
+  // GFC before previous GFS is acked.
+  process_->sink().ClearMessages();
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingStart);
+  EXPECT_TRUE(host_->fling_in_progress_);
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(1U, process_->sink().message_count());
+  EXPECT_FALSE(host_->coalesced_gesture_events_.empty());
+
+  // Advance state realistically.
+  SendInputEventACK(WebInputEvent::GestureFlingStart, true);
+  MessageLoop::current()->RunAllPending();
+  SendInputEventACK(WebInputEvent::GestureFlingCancel, true);
+  MessageLoop::current()->RunAllPending();
+  EXPECT_EQ(0U, host_->coalesced_gesture_events_.size());
+
+  // GFS is added to the queue if another event is pending
+  process_->sink().ClearMessages();
+  SimulateGestureEvent(8, -7, 0, WebInputEvent::GestureScrollUpdate);
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingStart);
+  EXPECT_EQ(1U, process_->sink().message_count());
+  WebGestureEvent merged_event = host_->coalesced_gesture_events_.back();
+  EXPECT_EQ(WebInputEvent::GestureFlingStart, merged_event.type);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(1U, host_->coalesced_gesture_events_.size());
+
+  // GFS in queue means that a GFC is added to the queue
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  merged_event = host_->coalesced_gesture_events_.back();
+  EXPECT_EQ(WebInputEvent::GestureFlingCancel, merged_event.type);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(2U, host_->coalesced_gesture_events_.size());
+
+
+  // Adding a second GFC is dropped.
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(2U, host_->coalesced_gesture_events_.size());
+
+  // Adding another GFS will add it to the queue.
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingStart);
+  merged_event = host_->coalesced_gesture_events_.back();
+  EXPECT_EQ(WebInputEvent::GestureFlingStart, merged_event.type);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(3U, host_->coalesced_gesture_events_.size());
+
+  // GFS in queue means that a GFC is added to the queue
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  merged_event = host_->coalesced_gesture_events_.back();
+  EXPECT_EQ(WebInputEvent::GestureFlingCancel, merged_event.type);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(4U, host_->coalesced_gesture_events_.size());
+
+  // Adding another GFC with a GFC already there is dropped.
+  SimulateGestureEvent(0, -10, 0, WebInputEvent::GestureFlingCancel);
+  merged_event = host_->coalesced_gesture_events_.back();
+  EXPECT_EQ(WebInputEvent::GestureFlingCancel, merged_event.type);
+  EXPECT_FALSE(host_->fling_in_progress_);
+  EXPECT_EQ(4U, host_->coalesced_gesture_events_.size());
+
+}
+
 // Test that the hang monitor timer expires properly if a new timer is started
 // while one is in progress (see crbug.com/11007).
 TEST_F(RenderWidgetHostTest, DontPostponeHangMonitorTimeout) {
   // Start with a short timeout.
   host_->StartHangMonitorTimeout(TimeDelta::FromMilliseconds(10));
 
   // Immediately try to add a long 30 second timeout.
   EXPECT_FALSE(host_->unresponsive_timer_fired());
   host_->StartHangMonitorTimeout(TimeDelta::FromSeconds(30));
 
@@ skipping 51 matching lines @@
   SimulateKeyboardEvent(WebInputEvent::RawKeyDown);
   SimulateKeyboardEvent(WebInputEvent::RawKeyDown);
   SendInputEventACK(WebInputEvent::RawKeyDown, true);
 
   // Wait long enough for first timeout and see if it fired.
   MessageLoop::current()->PostDelayedTask(
       FROM_HERE, MessageLoop::QuitClosure(), TimeDelta::FromMilliseconds(40));
   MessageLoop::current()->Run();
   EXPECT_TRUE(host_->unresponsive_timer_fired());
 }