chrome/common/extensions/extension_file_util.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_file_util.cc

diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc

index c02c82935e6a7887c881b80f5047a6428b1b641b..547b0fa0a2a350def33fbae4ffa7fbf41b74b393 100644

--- a/chrome/common/extensions/extension_file_util.cc

+++ b/chrome/common/extensions/extension_file_util.cc

@@ -654,9 +654,8 @@ bool CheckForIllegalFilenames(const FilePath& extension_path,

file_util::FileEnumerator all_files(

extension_path,

false,

- static_cast<file_util::FileEnumerator::FileType>(

- file_util::FileEnumerator::DIRECTORIES |

- file_util::FileEnumerator::FILES));

+ (file_util::FileEnumerator::DIRECTORIES |

+ file_util::FileEnumerator::FILES));

not at google - send to devlin 2012/08/06 05:04:56 extra parens seem unnecessary

Haruki Sato 2012/08/06 23:22:18 Ack. replied to another comment.

not at google - send to devlin 2012/08/06 23:28:18 You could assign to a kFilesAndDirectories constan

Haruki Sato 2012/08/07 02:29:17 Done.

FilePath file;

while (!(file = all_files.Next()).empty()) {

« chrome/browser/ui/webui/chromeos/drive_internals_ui.cc ('K') | « chrome/browser/ui/webui/chromeos/drive_internals_ui.cc ('k') | chrome/common/zip.cc » ('j') | chrome/common/zip.cc » ('J')