base/file_util.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/file_util.cc

diff --git a/base/file_util.cc b/base/file_util.cc

index d536475485645fa0c232ac6017af0c8182569b5f..f5f2ab2fbe5be9de3a14dba46718acb5145d8202 100644

--- a/base/file_util.cc

+++ b/base/file_util.cc

@@ -170,8 +170,7 @@ bool ReadFileToString(const FilePath& path, std::string* contents) {

bool IsDirectoryEmpty(const FilePath& dir_path) {

FileEnumerator files(dir_path, false,

- static_cast<FileEnumerator::FileType>(

- FileEnumerator::FILES | FileEnumerator::DIRECTORIES));

+ (FileEnumerator::FILES | FileEnumerator::DIRECTORIES));

jar (doing other things) 2012/08/06 18:27:02 nit: parens don't seem needed (or add to readabili

if (files.Next().value().empty())

return true;

return false;

« base/file_util.h ('K') | « base/file_util.h ('k') | base/file_util_posix.cc » ('j') | base/file_util_posix.cc » ('J')