Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: base/file_util_unittest.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed the comments about constant names. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 int mode = 0; 123 int mode = 0;
124 ASSERT_TRUE(file_util::GetPosixFilePermissions(path, &mode)); 124 ASSERT_TRUE(file_util::GetPosixFilePermissions(path, &mode));
125 mode |= mode_bits_to_set; 125 mode |= mode_bits_to_set;
126 mode &= ~mode_bits_to_clear; 126 mode &= ~mode_bits_to_clear;
127 ASSERT_TRUE(file_util::SetPosixFilePermissions(path, mode)); 127 ASSERT_TRUE(file_util::SetPosixFilePermissions(path, mode));
128 } 128 }
129 #endif // defined(OS_POSIX) 129 #endif // defined(OS_POSIX)
130 130
131 const wchar_t bogus_content[] = L"I'm cannon fodder."; 131 const wchar_t bogus_content[] = L"I'm cannon fodder.";
132 132
133 const file_util::FileEnumerator::FileType FILES_AND_DIRECTORIES = 133 const int FILES_AND_DIRECTORIES =
134 static_cast<file_util::FileEnumerator::FileType>( 134 file_util::FileEnumerator::FILES | file_util::FileEnumerator::DIRECTORIES;
135 file_util::FileEnumerator::FILES |
136 file_util::FileEnumerator::DIRECTORIES);
137 135
138 // file_util winds up using autoreleased objects on the Mac, so this needs 136 // file_util winds up using autoreleased objects on the Mac, so this needs
139 // to be a PlatformTest 137 // to be a PlatformTest
140 class FileUtilTest : public PlatformTest { 138 class FileUtilTest : public PlatformTest {
141 protected: 139 protected:
142 virtual void SetUp() OVERRIDE { 140 virtual void SetUp() OVERRIDE {
143 PlatformTest::SetUp(); 141 PlatformTest::SetUp();
144 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 142 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
145 } 143 }
146 144
(...skipping 1709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1856 } 1854 }
1857 1855
1858 TEST_F(FileUtilTest, FileEnumeratorTest) { 1856 TEST_F(FileUtilTest, FileEnumeratorTest) {
1859 // Test an empty directory. 1857 // Test an empty directory.
1860 file_util::FileEnumerator f0(temp_dir_.path(), true, FILES_AND_DIRECTORIES); 1858 file_util::FileEnumerator f0(temp_dir_.path(), true, FILES_AND_DIRECTORIES);
1861 EXPECT_EQ(f0.Next().value(), FILE_PATH_LITERAL("")); 1859 EXPECT_EQ(f0.Next().value(), FILE_PATH_LITERAL(""));
1862 EXPECT_EQ(f0.Next().value(), FILE_PATH_LITERAL("")); 1860 EXPECT_EQ(f0.Next().value(), FILE_PATH_LITERAL(""));
1863 1861
1864 // Test an empty directory, non-recursively, including "..". 1862 // Test an empty directory, non-recursively, including "..".
1865 file_util::FileEnumerator f0_dotdot(temp_dir_.path(), false, 1863 file_util::FileEnumerator f0_dotdot(temp_dir_.path(), false,
1866 static_cast<file_util::FileEnumerator::FileType>( 1864 FILES_AND_DIRECTORIES | file_util::FileEnumerator::INCLUDE_DOT_DOT);
1867 FILES_AND_DIRECTORIES | file_util::FileEnumerator::INCLUDE_DOT_DOT));
1868 EXPECT_EQ(temp_dir_.path().Append(FILE_PATH_LITERAL("..")).value(), 1865 EXPECT_EQ(temp_dir_.path().Append(FILE_PATH_LITERAL("..")).value(),
1869 f0_dotdot.Next().value()); 1866 f0_dotdot.Next().value());
1870 EXPECT_EQ(FILE_PATH_LITERAL(""), 1867 EXPECT_EQ(FILE_PATH_LITERAL(""),
1871 f0_dotdot.Next().value()); 1868 f0_dotdot.Next().value());
1872 1869
1873 // create the directories 1870 // create the directories
1874 FilePath dir1 = temp_dir_.path().Append(FILE_PATH_LITERAL("dir1")); 1871 FilePath dir1 = temp_dir_.path().Append(FILE_PATH_LITERAL("dir1"));
1875 EXPECT_TRUE(file_util::CreateDirectory(dir1)); 1872 EXPECT_TRUE(file_util::CreateDirectory(dir1));
1876 FilePath dir2 = temp_dir_.path().Append(FILE_PATH_LITERAL("dir2")); 1873 FilePath dir2 = temp_dir_.path().Append(FILE_PATH_LITERAL("dir2"));
1877 EXPECT_TRUE(file_util::CreateDirectory(dir2)); 1874 EXPECT_TRUE(file_util::CreateDirectory(dir2));
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
1912 1909
1913 // Only enumerate directories non-recursively. 1910 // Only enumerate directories non-recursively.
1914 file_util::FileEnumerator f2_non_recursive( 1911 file_util::FileEnumerator f2_non_recursive(
1915 temp_dir_.path(), false, file_util::FileEnumerator::DIRECTORIES); 1912 temp_dir_.path(), false, file_util::FileEnumerator::DIRECTORIES);
1916 FindResultCollector c2_non_recursive(f2_non_recursive); 1913 FindResultCollector c2_non_recursive(f2_non_recursive);
1917 EXPECT_TRUE(c2_non_recursive.HasFile(dir1)); 1914 EXPECT_TRUE(c2_non_recursive.HasFile(dir1));
1918 EXPECT_TRUE(c2_non_recursive.HasFile(dir2)); 1915 EXPECT_TRUE(c2_non_recursive.HasFile(dir2));
1919 EXPECT_EQ(c2_non_recursive.size(), 2); 1916 EXPECT_EQ(c2_non_recursive.size(), 2);
1920 1917
1921 // Only enumerate directories, non-recursively, including "..". 1918 // Only enumerate directories, non-recursively, including "..".
1922 file_util::FileEnumerator f2_dotdot( 1919 file_util::FileEnumerator f2_dotdot(temp_dir_.path(), false,
1923 temp_dir_.path(), false, 1920 (file_util::FileEnumerator::DIRECTORIES |
1924 static_cast<file_util::FileEnumerator::FileType>( 1921 file_util::FileEnumerator::INCLUDE_DOT_DOT));
1925 file_util::FileEnumerator::DIRECTORIES |
1926 file_util::FileEnumerator::INCLUDE_DOT_DOT));
1927 FindResultCollector c2_dotdot(f2_dotdot); 1922 FindResultCollector c2_dotdot(f2_dotdot);
1928 EXPECT_TRUE(c2_dotdot.HasFile(dir1)); 1923 EXPECT_TRUE(c2_dotdot.HasFile(dir1));
1929 EXPECT_TRUE(c2_dotdot.HasFile(dir2)); 1924 EXPECT_TRUE(c2_dotdot.HasFile(dir2));
1930 EXPECT_TRUE(c2_dotdot.HasFile( 1925 EXPECT_TRUE(c2_dotdot.HasFile(
1931 temp_dir_.path().Append(FILE_PATH_LITERAL("..")))); 1926 temp_dir_.path().Append(FILE_PATH_LITERAL(".."))));
1932 EXPECT_EQ(c2_dotdot.size(), 3); 1927 EXPECT_EQ(c2_dotdot.size(), 3);
1933 1928
1934 // Enumerate files and directories. 1929 // Enumerate files and directories.
1935 file_util::FileEnumerator f3(temp_dir_.path(), true, FILES_AND_DIRECTORIES); 1930 file_util::FileEnumerator f3(temp_dir_.path(), true, FILES_AND_DIRECTORIES);
1936 FindResultCollector c3(f3); 1931 FindResultCollector c3(f3);
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
2459 file_util::VerifyPathControlledByUser( 2454 file_util::VerifyPathControlledByUser(
2460 base_dir_, text_file_, uid_, ok_gids_)); 2455 base_dir_, text_file_, uid_, ok_gids_));
2461 EXPECT_TRUE( 2456 EXPECT_TRUE(
2462 file_util::VerifyPathControlledByUser( 2457 file_util::VerifyPathControlledByUser(
2463 sub_dir_, text_file_, uid_, ok_gids_)); 2458 sub_dir_, text_file_, uid_, ok_gids_));
2464 } 2459 }
2465 2460
2466 #endif // defined(OS_POSIX) 2461 #endif // defined(OS_POSIX)
2467 2462
2468 } // namespace 2463 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698