ResourceId and unit test cleanup.

chrome/browser/chromeos/gdata/gdata_files.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_files.h"
 
 #include "base/platform_file.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 15 matching lines @@
 }
 
 }  // namespace
 
 // GDataEntry class.
 
 GDataEntry::GDataEntry(GDataDirectoryService* directory_service)
     : parent_(NULL),
       directory_service_(directory_service),
       deleted_(false) {
+  DCHECK(directory_service);
 }
 
 GDataEntry::~GDataEntry() {
 }
 
 GDataFile* GDataEntry::AsGDataFile() {
   return NULL;
 }
 
 GDataDirectory* GDataEntry::AsGDataDirectory() {
@@ skipping 183 matching lines @@
     }
   }
   entry->set_base_name(full_file_name.value());
 
   DVLOG(1) << "AddEntry: dir = " << GetFilePath().value()
            << ", file = " + entry->base_name()
            << ", parent resource = " << entry->parent_resource_id()
            << ", resource = " + entry->resource_id();
 
   // Add entry to resource map.
-  if (directory_service_)
-    directory_service_->AddEntryToResourceMap(entry);
+  directory_service_->AddEntryToResourceMap(entry);
 
   // Setup child and parent links.
   AddChild(entry);
   entry->SetParent(this);
 }
 
 bool GDataDirectory::TakeOverEntries(GDataDirectory* dir) {
-  for (GDataFileCollection::iterator iter = dir->child_files_.begin();
+  for (GDataFileCollection::const_iterator iter = dir->child_files_.begin();
        iter != dir->child_files_.end(); ++iter) {
     GDataEntry* entry = iter->second;
+    directory_service_->RemoveEntryFromResourceMap(entry->resource_id());
     entry->SetParent(NULL);
     AddEntry(entry);
   }
   dir->child_files_.clear();
 
   for (GDataDirectoryCollection::iterator iter =
       dir->child_directories_.begin();
        iter != dir->child_directories_.end(); ++iter) {
     GDataEntry* entry = iter->second;
+    directory_service_->RemoveEntryFromResourceMap(entry->resource_id());
     entry->SetParent(NULL);
     AddEntry(entry);
   }
   dir->child_directories_.clear();
   return true;
 }
 
 void GDataDirectory::RemoveEntry(GDataEntry* entry) {
   DCHECK(entry);
 
   RemoveChild(entry);
   delete entry;
 }
 
 GDataEntry* GDataDirectory::FindChild(
     const FilePath::StringType& file_name) const {
-  GDataFileCollection::const_iterator it = child_files_.find(file_name);
-  if (it != child_files_.end())
-    return it->second;
+  GDataFileCollection::const_iterator iter = child_files_.find(file_name);
+  if (iter != child_files_.end())
+    return iter->second;
 
   GDataDirectoryCollection::const_iterator itd =
       child_directories_.find(file_name);
   if (itd != child_directories_.end())
     return itd->second;
 
   return NULL;
 }
 
 void GDataDirectory::AddChild(GDataEntry* entry) {
   DCHECK(entry);
 
-  GDataFile* file = entry->AsGDataFile();
-  if (file)
-    child_files_.insert(std::make_pair(entry->base_name(), file));
+  if (entry->AsGDataFile())
+    child_files_.insert(std::make_pair(entry->base_name(),
+                                       entry->AsGDataFile()));
 
-  GDataDirectory* directory = entry->AsGDataDirectory();
-  if (directory)
-    child_directories_.insert(std::make_pair(entry->base_name(), directory));
+  if (entry->AsGDataDirectory())
+    child_directories_.insert(std::make_pair(entry->base_name(),
+                                             entry->AsGDataDirectory()));
 }
 
 void GDataDirectory::RemoveChild(GDataEntry* entry) {
   DCHECK(entry);
 
   const std::string& base_name(entry->base_name());
   // entry must be present in this directory.
   DCHECK_EQ(entry, FindChild(base_name));
   // Remove entry from resource map first.
-  if (directory_service_)
-    directory_service_->RemoveEntryFromResourceMap(entry);
+  directory_service_->RemoveEntryFromResourceMap(entry->resource_id());
 
   // Then delete it from tree.
   child_files_.erase(base_name);
   child_directories_.erase(base_name);
 
   entry->SetParent(NULL);
 }
 
 void GDataDirectory::RemoveChildren() {
   RemoveChildFiles();
   RemoveChildDirectories();
 }
 
 void GDataDirectory::RemoveChildFiles() {
+  DVLOG(1) << "RemoveChildFiles " << resource_id();
   for (GDataFileCollection::const_iterator iter = child_files_.begin();
        iter != child_files_.end(); ++iter) {
-    if (directory_service_)
-      directory_service_->RemoveEntryFromResourceMap(iter->second);
+    directory_service_->RemoveEntryFromResourceMap(iter->second->resource_id());
   }
   STLDeleteValues(&child_files_);
   child_files_.clear();
 }
 
 void GDataDirectory::RemoveChildDirectories() {
   for (GDataDirectoryCollection::iterator iter = child_directories_.begin();
        iter != child_directories_.end(); ++iter) {
     GDataDirectory* dir = iter->second;
     // Remove directories recursively.
     dir->RemoveChildren();
-    if (directory_service_)
-      directory_service_->RemoveEntryFromResourceMap(dir);
+    directory_service_->RemoveEntryFromResourceMap(dir->resource_id());
   }
   STLDeleteValues(&child_directories_);
   child_directories_.clear();
 }
 
+// Recursively extracts the paths set of all sub-directories.

[satorux1, 2012/08/17 11:49:17]

remove this comment?

[achuithb, 2012/08/17 21:02:27]

Done.

+void GDataDirectory::GetChildDirectoryPaths(std::set<FilePath>* child_dirs) {
+  for (GDataDirectoryCollection::const_iterator it = child_directories_.begin();
+       it != child_directories_.end(); ++it) {
+    GDataDirectory* child_dir = it->second;
+    child_dirs->insert(child_dir->GetFilePath());
+    child_dir->GetChildDirectoryPaths(child_dirs);
+  }
+}
+
 // Convert to/from proto.
 
 // static
 void GDataEntry::ConvertProtoToPlatformFileInfo(
     const PlatformFileInfoProto& proto,
     base::PlatformFileInfo* file_info) {
   file_info->size = proto.size();
   file_info->is_directory = proto.is_directory();
   file_info->is_symbolic_link = proto.is_symbolic_link();
   file_info->last_modified = base::Time::FromInternalValue(
@@ skipping 136 matching lines @@
   for (GDataDirectoryCollection::const_iterator iter =
        child_directories_.begin();
        iter != child_directories_.end(); ++iter) {
     GDataDirectory* dir = iter->second;
     dir->ToProto(proto->add_child_directories());
   }
 }
 
 scoped_ptr<GDataEntryProtoVector> GDataDirectory::ToProtoVector() const {
   scoped_ptr<GDataEntryProtoVector> entries(new GDataEntryProtoVector);
-  for (GDataFileCollection::const_iterator iter = child_files().begin();
-       iter != child_files().end(); ++iter) {
+  for (GDataFileCollection::const_iterator iter = child_files_.begin();
+       iter != child_files_.end(); ++iter) {
     GDataEntryProto proto;
     iter->second->ToProto(&proto);
     entries->push_back(proto);
   }
   for (GDataDirectoryCollection::const_iterator iter =
-           child_directories().begin();
-       iter != child_directories().end(); ++iter) {
+           child_directories_.begin();
+       iter != child_directories_.end(); ++iter) {
     GDataEntryProto proto;
     // Convert to GDataEntry, as we don't want to include children in |proto|.
     static_cast<const GDataEntry*>(iter->second)->ToProtoFull(&proto);
     entries->push_back(proto);
   }
 
   return entries.Pass();
 }
 
 void GDataEntry::SerializeToString(std::string* serialized_proto) const {
   const GDataFile* file = AsGDataFileConst();
   const GDataDirectory* dir = AsGDataDirectoryConst();
 
   if (file) {
     GDataEntryProto entry_proto;
     file->ToProto(&entry_proto);
     const bool ok = entry_proto.SerializeToString(serialized_proto);
     DCHECK(ok);
   } else if (dir) {
     GDataDirectoryProto dir_proto;
     dir->ToProto(&dir_proto);
     const bool ok = dir_proto.SerializeToString(serialized_proto);
     DCHECK(ok);
   }
 }
 
 }  // namespace gdata