Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: webkit/media/webmediaplayer_proxy.h

Issue 10854151: Allow transitioning to HAVE_METADATA before pipeline initialization completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comments and fix tests. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_proxy.h
diff --git a/webkit/media/webmediaplayer_proxy.h b/webkit/media/webmediaplayer_proxy.h
index 69e0e2cc246561223cea49d1a97009102b963f8b..f785e75abcacdb01a0577ae23910032a4a55d063 100644
--- a/webkit/media/webmediaplayer_proxy.h
+++ b/webkit/media/webmediaplayer_proxy.h
@@ -75,10 +75,10 @@ class WebMediaPlayerProxy
void AbortDataSource();
// Methods for Pipeline -> WebMediaPlayerImpl communication.
- void PipelineInitializationCallback(media::PipelineStatus status);
void PipelineSeekCallback(media::PipelineStatus status);
void PipelineEndedCallback(media::PipelineStatus status);
void PipelineErrorCallback(media::PipelineStatus error);
+ void PipelineReadyStateCallback(media::Pipeline::ReadyState readyState);
scherkus (not reviewing) 2012/08/15 23:43:16 unix_hacker
acolwell GONE FROM CHROMIUM 2012/08/16 00:54:18 Done.
// ChunkDemuxerClient implementation.
virtual void DemuxerOpened(media::ChunkDemuxer* demuxer) OVERRIDE;
@@ -124,9 +124,6 @@ class WebMediaPlayerProxy
// Invoke |webmediaplayer_| to perform a repaint.
void RepaintTask();
- // Notify |webmediaplayer_| that initialization has finished.
- void PipelineInitializationTask(media::PipelineStatus status);
-
// Notify |webmediaplayer_| that a seek has finished.
void PipelineSeekTask(media::PipelineStatus status);
@@ -137,6 +134,9 @@ class WebMediaPlayerProxy
// playback.
void PipelineErrorTask(media::PipelineStatus error);
+ // Notify |webmediaplayer_| of readyState changes.
scherkus (not reviewing) 2012/08/15 23:43:16 unix_hacker
acolwell GONE FROM CHROMIUM 2012/08/16 00:54:18 Done.
+ void PipelineReadyStateTask(media::Pipeline::ReadyState readyState);
scherkus (not reviewing) 2012/08/15 23:43:16 unix_hacker
acolwell GONE FROM CHROMIUM 2012/08/16 00:54:18 Done.
+
// Inform |webmediaplayer_| whether the video content is opaque.
void SetOpaqueTask(bool opaque);

Powered by Google App Engine
This is Rietveld 408576698