Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: media/base/pipeline_unittest.cc

Issue 10854151: Allow transitioning to HAVE_METADATA before pipeline initialization completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index 5b502050611a1a4defc721b77f22c4b929f55166..a795203bbda5b8f50c09fe0ce43d07817034265a 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -78,6 +78,7 @@ class CallbackHelper {
MOCK_METHOD0(OnStop, void());
MOCK_METHOD1(OnEnded, void(PipelineStatus));
MOCK_METHOD1(OnError, void(PipelineStatus));
+ MOCK_METHOD1(OnReadyState, void(Pipeline::ReadyState));
private:
DISALLOW_COPY_AND_ASSIGN(CallbackHelper);
@@ -234,7 +235,9 @@ class PipelineTest : public ::testing::Test {
mocks_->Create().Pass(),
base::Bind(&CallbackHelper::OnEnded, base::Unretained(&callbacks_)),
base::Bind(&CallbackHelper::OnError, base::Unretained(&callbacks_)),
- base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)));
+ base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)),
+ base::Bind(&CallbackHelper::OnReadyState,
+ base::Unretained(&callbacks_)));
message_loop_.RunAllPending();
}
@@ -356,7 +359,9 @@ TEST_F(PipelineTest, NeverInitializes) {
mocks_->Create().Pass(),
base::Bind(&CallbackHelper::OnEnded, base::Unretained(&callbacks_)),
base::Bind(&CallbackHelper::OnError, base::Unretained(&callbacks_)),
- base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)));
+ base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)),
+ base::Bind(&CallbackHelper::OnReadyState,
+ base::Unretained(&callbacks_)));
message_loop_.RunAllPending();
@@ -377,7 +382,9 @@ TEST_F(PipelineTest, RequiredFilterMissing) {
collection.Pass(),
base::Bind(&CallbackHelper::OnEnded, base::Unretained(&callbacks_)),
base::Bind(&CallbackHelper::OnError, base::Unretained(&callbacks_)),
- base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)));
+ base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)),
+ base::Bind(&CallbackHelper::OnReadyState,
+ base::Unretained(&callbacks_)));
message_loop_.RunAllPending();
}
@@ -998,7 +1005,9 @@ class PipelineTeardownTest : public PipelineTest {
mocks_->Create().Pass(),
base::Bind(&CallbackHelper::OnEnded, base::Unretained(&callbacks_)),
base::Bind(&CallbackHelper::OnError, base::Unretained(&callbacks_)),
- base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)));
+ base::Bind(&CallbackHelper::OnStart, base::Unretained(&callbacks_)),
+ base::Bind(&CallbackHelper::OnReadyState,
+ base::Unretained(&callbacks_)));
message_loop_.RunAllPending();
}

Powered by Google App Engine
This is Rietveld 408576698