Issue 10854131: Remove obsolete webkit_glue::P2PTransport interface.

Issue 10854131: Remove obsolete webkit_glue::P2PTransport interface. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov

Modified:
8 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove obsolete webkit_glue::P2PTransport interface. The P2PTransport interface was used to implement PPB_Transport_Dev Pepper interface. That interface was removed a while ago. Removing webkit_glue::P2PTransport too as we don't need it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151813

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -967 lines)			Patch
M	content/content_renderer.gypi	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/media/media_stream_dependency_factory.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/media/media_stream_dependency_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	content/renderer/p2p/p2p_transport_impl.h	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	content/renderer/p2p/p2p_transport_impl.cc	View	1 2 3	1 chunk	+0 lines, -174 lines	0 comments	Download
D	content/renderer/p2p/p2p_transport_impl_unittest.cc	View		1 chunk	+0 lines, -530 lines	0 comments	Download
M	content/renderer/p2p/port_allocator.h	View	1 2 3	3 chunks	+30 lines, -5 lines	0 comments	Download
M	content/renderer/p2p/port_allocator.cc	View	1 2 3 4	1 chunk	+11 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download
D	webkit/glue/p2p_transport.h	View		1 chunk	+0 lines, -113 lines	0 comments	Download
D	webkit/glue/p2p_transport.cc	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

brettw

I don't really understand the addition of the Config struct in here. Was that a ...

8 years, 4 months ago (2012-08-15 19:18:49 UTC) #2

Sergey Ulanov

> I don't really understand the addition of the Config > struct in here. Was ...

8 years, 4 months ago (2012-08-15 19:25:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10854131/6003

8 years, 4 months ago (2012-08-15 19:35:56 UTC) #5

commit-bot: I haz the power

Try job failure for 10854131-6003 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=48008 Step "update" is always ...

8 years, 4 months ago (2012-08-15 20:07:38 UTC) #6

commit-bot: I haz the power

8 years, 4 months ago (2012-08-15 23:18:54 UTC) #7

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10854131/7037

Expand Messages | Collapse Messages