Show an extra privacy warning on Win8

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 1173 matching lines @@
 
     /**
      * Show/hide touchpad settings slider.
      * @private
      */
     showTouchpadControls_: function(show) {
       $('touchpad-settings').hidden = !show;
     },
 
     /**
+     * Show/hide Windows 8 data privacy warning.
+     * @private
+     */
+    showWin8DataPrivacy_: function() {
+      $('privacy-win8-data-settings').hidden = false;

[arv (Not doing code reviews), 2012/08/15 14:33:31]

How about, in initializePage we do:

var m = /Windows NT (\d+(?:\.\d+))?/.exec(navigator.userAgent)
var isWin8 =  m && m[1] > 6.2;
var win8Element = $('privacy-win8-data-settings');
if (win8Element)
  win8Element.hidden = !isWin8;

[MAD, 2012/08/15 19:29:41]

Ho! Cool, I didn't think about that...
Thanks!... Done!

+    },
+
+    /**
      * Show/hide the display options button on the System settings page.
      * @private
      */
     showDisplayOptions_: function(show) {
       $('display-options-section').hidden = !show;
     },
 
     /**
      * Activate the bluetooth settings section on the System settings page.
      * @private
@@ skipping 107 matching lines @@
     'setSpokenFeedbackCheckboxState',
     'setThemesResetButtonEnabled',
     'setupCloudPrintConnectorSection',
     'setupPageZoomSelector',
     'setupProxySettingsSection',
     'setVirtualKeyboardCheckboxState',
     'showBluetoothSettings',
     'showDisplayOptions',
     'showMouseControls',
     'showTouchpadControls',
+    'showWin8DataPrivacy',
     'updateAccountPicture',
     'updateAutoLaunchState',
     'updateDefaultBrowserState',
     'updateManagedBannerVisibility',
     'updateSearchEngines',
     'updateSyncState',
     'updateStartupPages',
   ].forEach(function(name) {
     BrowserOptions[name] = function() {
       var instance = BrowserOptions.getInstance();
@@ skipping 10 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });