Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/chromeos/cros/network_library_impl_cros.cc

Issue 10854112: Fix always-in-roaming reset loop for cellular connections on Chromium OS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library_impl_cros.cc
diff --git a/chrome/browser/chromeos/cros/network_library_impl_cros.cc b/chrome/browser/chromeos/cros/network_library_impl_cros.cc
index 21b12a53f052abba6c5d32e0d5012c8614f42761..3a38a3afffca0812c8e56e3fae8b88795a42b239 100644
--- a/chrome/browser/chromeos/cros/network_library_impl_cros.cc
+++ b/chrome/browser/chromeos/cros/network_library_impl_cros.cc
@@ -25,7 +25,8 @@ namespace {
// List of cellular operators names that should have data roaming always enabled
// to be able to connect to any network.
const char* kAlwaysInRoamingOperators[] = {
- "CUBIC"
+ "CUBIC",
+ "Cubic",
};
// List of interfaces that have portal check enabled by default.
@@ -164,8 +165,9 @@ void NetworkLibraryImplCros::UpdateNetworkDeviceStatus(
bool NetworkLibraryImplCros::UpdateCellularDeviceStatus(
NetworkDevice* device, PropertyIndex index) {
if (index == PROPERTY_INDEX_CELLULAR_ALLOW_ROAMING) {
- if (!device->data_roaming_allowed() && IsCellularAlwaysInRoaming()) {
- SetCellularDataRoamingAllowed(true);
+ if (IsCellularAlwaysInRoaming()) {
+ if (!device->data_roaming_allowed())
+ SetCellularDataRoamingAllowed(true);
} else {
bool settings_value;
if ((CrosSettings::Get()->GetBoolean(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698