Issue 10854079: Address post commit comments for CL 10828201

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854079: Address post commit comments for CL 10828201 (Closed)

Created:
8 years, 4 months ago by markusheintz_

Modified:
8 years, 4 months ago

Reviewers:
tfarina, msw

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/website_settings/website_settings_popup_view.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/website_settings/website_settings_popup_view.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

msw

LGTM. FYI, I think Bubble is better name, especially considering that it derives from BubbleDelegateView, ...

8 years, 4 months ago (2012-08-10 00:54:31 UTC) #2

markusheintz_

On 2012/08/10 00:55:03, tfarina wrote: > lgtm Thanks a lot for the review.

8 years, 4 months ago (2012-08-10 09:41:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10854079/1

8 years, 4 months ago (2012-08-10 09:41:38 UTC) #5

Change committed as 151020